Skip to content

Bump SDK to 8.0.100-alpha.1.22616.4 #44925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Dec 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions global.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"sdk": {
"version": "8.0.100-alpha.1.22531.1"
"version": "8.0.100-alpha.1.22616.4"
},
"tools": {
"dotnet": "8.0.100-alpha.1.22531.1",
"dotnet": "8.0.100-alpha.1.22616.4",
"runtimes": {
"dotnet/x86": [
"$(MicrosoftNETCoreBrowserDebugHostTransportVersion)"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,13 @@ internal void GetHandlerActions(
{
bool methodFound = false;

if (GetUpdateMethod(handlerType, "ClearCache") is MethodInfo clearCache)
if (GetUpdateMethod("ClearCache") is MethodInfo clearCache)
{
handlerActions.ClearCache.Add(CreateAction(clearCache));
methodFound = true;
}

if (GetUpdateMethod(handlerType, "UpdateApplication") is MethodInfo updateApplication)
if (GetUpdateMethod("UpdateApplication") is MethodInfo updateApplication)
{
handlerActions.UpdateApplication.Add(CreateAction(updateApplication));
methodFound = true;
Expand Down Expand Up @@ -129,7 +129,7 @@ internal void GetHandlerActions(
};
}

MethodInfo? GetUpdateMethod([DynamicallyAccessedMembers(HotReloadHandlerLinkerFlags)] Type handlerType, string name)
MethodInfo? GetUpdateMethod(string name)
{
if (handlerType.GetMethod(name, BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Static, new[] { typeof(Type[]) }) is MethodInfo updateMethod &&
updateMethod.ReturnType == typeof(void))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public async Task RequestBodyTooLargeContentLengthExceedsGlobalLimit()
catch (BadHttpRequestException ex)
{
exception = ex;
throw ex;
throw;
}
}, LoggerFactory))
{
Expand Down Expand Up @@ -80,7 +80,7 @@ public async Task RequestBodyTooLargeContentLengthExceedingPerRequestLimit()
catch (BadHttpRequestException ex)
{
exception = ex;
throw ex;
throw;
}
}, LoggerFactory, new IISServerOptions { MaxRequestBodySize = maxRequestSize }))
{
Expand Down Expand Up @@ -286,7 +286,7 @@ public async Task RequestBodyTooLargeChunked()
catch (BadHttpRequestException ex)
{
exception = ex;
throw ex;
throw;
}
}, LoggerFactory, new IISServerOptions { MaxRequestBodySize = maxRequestSize }))
{
Expand Down