Update selenium dependency versions #44834

captainsafia · 2022-11-02T02:32:37Z

No description provided.

captainsafia · 2022-11-02T20:59:01Z

/azp run

azure-pipelines · 2022-11-02T20:59:19Z

Azure Pipelines successfully started running 3 pipeline(s).

dougbu

Some big jumps. Hope they don't include breaking changes…

src/Components/benchmarkapps/Wasm.Performance/dockerfile

dougbu · 2022-11-02T22:51:33Z

/azp run

azure-pipelines · 2022-11-02T22:51:53Z

Azure Pipelines successfully started running 3 pipeline(s).

captainsafia · 2022-11-03T00:20:26Z

Some big jumps. Hope they don't include breaking changes…

Yeah, it looks like the last time this was updated was August 1st so we're a little behind. Hopefully, not any breaking changes here...

dougbu · 2022-11-03T00:26:29Z

Due to the https://github.com/dotnet/aspnetcore/blob/07a563e1ed6d443a8e8dce6c4fe78a6aad5302df/src/Components/test/E2ETest/.npmrc file, you'll need to get vsts-npm-auth and use vsts-npm-auth -C {that file} before running yarn install in that directory

javiercn · 2022-11-03T09:16:40Z

Due to the https://github.com/dotnet/aspnetcore/blob/07a563e1ed6d443a8e8dce6c4fe78a6aad5302df/src/Components/test/E2ETest/.npmrc file, you'll need to get vsts-npm-auth and use vsts-npm-auth -C {that file} before running yarn install in that directory

Where are we supposed to run this?

dougbu · 2022-11-03T18:16:23Z

Where are we supposed to run this?

In the same directory as that .npmrc and the changed package.json file.

dougbu · 2022-11-03T18:19:09Z

The system automatically loads packages from upstream repositories into the one listed in the .npmrc file when an authorized person runs yarn install. That means only authorized people (like you) can change what we depend on.

It may also be necessary to clear your local yarn cache before installing and updating the lock file.

javiercn · 2022-11-03T19:25:32Z

@dougbu what I meant is, does vsts-npm-auth need to go on a ~~yarn~~ YAML file?

dougbu · 2022-11-03T19:37:57Z

No, execute it from the command line using the .npmrc file I mentioned. Then, you're authenticated and yarn install should do the right thing, assuming your cache is clear and you don't have a node_modules/ folder in the directory.

Not sure but always-auth=true may temporarily (don't check the change in) need to be added to the .npmrc file.

https://learn.microsoft.com/en-us/azure/devops/artifacts/tutorials/protect-oss-packages-with-upstream-sources?view=azure-devops&tabs=npm%2Cnpmrestore is pretty general but has a bit more context.

dougbu · 2022-11-07T19:33:39Z

@captainsafia @javiercn where exactly is this PR❔ Do one of you already have updated lock files on your machines❔

javiercn · 2022-11-07T19:44:24Z

@dougbu I do not 😢. Had to look into other build issues.

dougbu · 2022-11-19T00:15:12Z

@dotnet/aspnet-blazor-eng I updated the lock files and we're getting further. But it appears the newer packages include a breaking change:

> selenium-standalone start --config /home/vsts/work/1/s/src/Shared/E2ETesting/selenium-config.json --javaArgs=-Dwebdriver.chrome.driver=/usr/local/share/chrome_driver/chromedriver -- -port 44457
[xUnit.net 00:00:02.56] Microsoft.AspNetCore.Components.E2ETests: 
[xUnit.net 00:00:02.83] Microsoft.AspNetCore.Components.E2ETests: Unrecognized option: -
[xUnit.net 00:00:02.83] Microsoft.AspNetCore.Components.E2ETests: Error: Could not create the Java Virtual Machine.
[xUnit.net 00:00:02.83] Microsoft.AspNetCore.Components.E2ETests: Error: A fatal exception has occurred. Program will exit.
[xUnit.net 00:00:03.27] Microsoft.AspNetCore.Components.E2ETests: /home/vsts/work/1/s/src/Components/test/E2ETest/node_modules/selenium-standalone/lib/check-started.js:44
[xUnit.net 00:00:03.27] Microsoft.AspNetCore.Components.E2ETests:       throw new Error(
[xUnit.net 00:00:03.27] Microsoft.AspNetCore.Components.E2ETests:             ^
[xUnit.net 00:00:03.27] Microsoft.AspNetCore.Components.E2ETests: 
[xUnit.net 00:00:03.27] Microsoft.AspNetCore.Components.E2ETests: Error: Selenium exited before it could start with code 1
[xUnit.net 00:00:03.27] Microsoft.AspNetCore.Components.E2ETests: Stdout: 
[xUnit.net 00:00:03.27] Microsoft.AspNetCore.Components.E2ETests: Stderr: 
[xUnit.net 00:00:03.27] Microsoft.AspNetCore.Components.E2ETests:     at checkStarted (/home/vsts/work/1/s/src/Components/test/E2ETest/node_modules/selenium-standalone/lib/check-started.js:44:13)
[xUnit.net 00:00:03.27] Microsoft.AspNetCore.Components.E2ETests:     at async Object.start (/home/vsts/work/1/s/src/Components/test/E2ETest/node_modules/selenium-standalone/lib/start.js:150:3)
[xUnit.net 00:00:03.27] Microsoft.AspNetCore.Components.E2ETests:     at async Object.start (/home/vsts/work/1/s/src/Components/test/E2ETest/node_modules/selenium-standalone/bin/selenium-standalone:23:16)

Didn't we hit something similar the last time we tried to move to a newer selenium-standalone❔

BrennanConroy · 2022-11-21T23:05:33Z

This seems like something the @dotnet/aspnet-blazor-eng team should investigate and fix. It's gotten too complex for normal build-ops to try to figure out.

BrennanConroy · 2022-11-24T00:35:17Z

src/Shared/E2ETesting/SeleniumStandaloneServer.cs

@@ -104,14 +104,18 @@ private static async Task InitializeInstance(ITestOutputHelper output)
        var chromeDriverPathEnvVar = Environment.GetEnvironmentVariable("CHROMEWEBDRIVER");
        if (!string.IsNullOrEmpty(chromeDriverPathEnvVar))
        {
-            chromeDriverArg = $"--javaArgs=-Dwebdriver.chrome.driver={chromeDriverPathEnvVar}/chromedriver";
+            var configContent = File.ReadAllText(seleniumConfigPath);


FYI, this is working around what is likely a bug in selenium-standalone introduced by webdriverio/selenium-standalone@d13777c#diff-20cb449399750b160a4adfac13aa25ed97c9faacf30bee11ed4a16870f3ff4bfR103
It expands the individual characters of the command line argument for --javaArgs, so -Dblah becomes ['-','D','b','l','a','h'] which then fails since each value in the array is passed as an argument to java and - isn't a valid argument.

Might be worth filing an issue.

TanayParikh · 2022-12-14T23:36:44Z

Made some additional bumps for Chrome 108 and associated selenium packages. Reverted the selenium-standalone bump for now.

TanayParikh · 2022-12-14T23:49:20Z

Latest packages aren't available in our feeds, have reached out offline to the appropriate folks.

TanayParikh · 2022-12-15T00:02:52Z

/azp run

azure-pipelines · 2022-12-15T00:03:09Z

Azure Pipelines successfully started running 3 pipeline(s).

TanayParikh · 2022-12-15T00:18:40Z

Packages are now available. Lock files need updating now.

TanayParikh · 2022-12-15T02:36:30Z

Progress?

Exception in thread "main" com.beust.jcommander.ParameterException: Was passed main parameter '--port' but no main parameter was defined in your arg class
	at com.beust.jcommander.JCommander.initMainParameterValue(JCommander.java:936)
	at com.beust.jcommander.JCommander.parseValues(JCommander.java:752)
	at com.beust.jcommander.JCommander.parse(JCommander.java:340)
	at com.beust.jcommander.JCommander.parse(JCommander.java:319)
	at org.openqa.grid.selenium.GridLauncherV3.parse(GridLauncherV3.java:218)
	at org.openqa.grid.selenium.GridLauncherV3.lambda$buildLaunchers$3(GridLauncherV3.java:241)
	at org.openqa.grid.selenium.GridLauncherV3.lambda$launch$0(GridLauncherV3.java:86)
	at java.base/java.util.Optional.map(Optional.java:265)
	at org.openqa.grid.selenium.GridLauncherV3.launch(GridLauncherV3.java:86)
	at org.openqa.grid.selenium.GridLauncherV3.main(GridLauncherV3.java:70)
/home/vsts/work/1/s/src/Components/test/E2ETest/node_modules/selenium-standalone/lib/check-started.js:23
      throw new Error(`Selenium exited before it could start with code ${cpState.code}\n`);
            ^

I think this may be related to the arg parsing @BrennanConroy mentioned above.

Hmm I'm seeing:

selenium-standalone start --config /home/vsts/work/1/s/src/Components/test/E2ETest/bin/Release/net7.0/modifiedConfig.json -- --port 44615

But that looks like it's expected:

https://github.com/dotnet/aspnetcore/pull/44834/files#diff-220c96679ae5c8b66a7c08d0514422c79c41bbf522874580097ce4dd6b6d8f1eL114-R118

@BrennanConroy are you able to share some more context on your earlier change?

Taking a shot by reverting the --port to the original -port: 5624bc7

TanayParikh · 2022-12-15T05:22:52Z

Okay, that worked, no more parameter error! Onto the next;

   System.InvalidOperationException : Couldn't create a Selenium remote driver client. The server is irresponsive
---- OpenQA.Selenium.WebDriverException : The newSession command returned an unexpected error.

Selenium
Whoops! The URL specified routes to this help page.

For more information about Selenium please see the docs and/or visit the wiki. Or perhaps you are looking for the Selenium console.

Happy Testing!

So running into some routing issue now.

Reverted the selenium standalone workaround.

This reverts commit 1a81a40.

BrennanConroy · 2022-12-15T05:41:49Z

are you able to share some more context on your earlier change?

#44834 (comment)

[main] Update dependencies from dotnet/efcore dotnet/runtime - Update templatestrings.json files - Update template.json files - Update other references to net7 - Rename publicApi folders - Fix RepoTasks - Fix it more fixily - Really fix it for real this time - Undo PreviewFeatures changes - Using - Merge branch 'darc-main-8caa276f-464b-4e95-a7fa-bc264a536653' of https://github.com/dotnet/aspnetcore into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653 - Tasks - IO - CTS - Net70 - Merge branch 'darc-main-8caa276f-464b-4e95-a7fa-bc264a536653' of https://github.com/dotnet/aspnetcore into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653 - Try using net8.0 for HelixTestRunner - Try making ReferenceAssemblies - Merge branch 'darc-main-8caa276f-464b-4e95-a7fa-bc264a536653' of https://github.com/dotnet/aspnetcore into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653 - Get analyzer tests working - Ok fine - Update doc - Path combine - Try somethin wacky - Fix - Using - Merge remote-tracking branch 'upstream/main' into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653 - Quarantine regressed WriteAsJsonAsync tests #45557 - Quarantine regressed async Json test #45557 - Re-order DataAnnotationsMetadataProviderTest expected results - Quarantine regressed async Json test #45557 - Re-order DataAnnotationsMetadataProviderTest expected results - Merge remote-tracking branch 'upstream/main' into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653 - Bump E2E timeout to 2 hours Per discussion in #44834 (comment) - React to enum ordering change - Merge remote-tracking branch 'upstream/darc-main-8caa276f-464b-4e95-a7fa-bc264a536653' into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653 - Skip a microbenchmark, update a version - Make test resilient to order changes - Unquar tests - remove custom loader for .wasm file (#45611)

TanayParikh · 2022-12-15T21:38:24Z

🤞 that should do it

TanayParikh · 2022-12-15T22:20:17Z

🎉

Going to auto-merge this now that it's green. Feel free to reach out if anybody has any questions or concerns.

sebastienros · 2022-12-15T22:22:42Z

Awesome work @TanayParikh 👏👏👏

Update selenium dependency versions

07a563e

dougbu approved these changes Nov 2, 2022

View reviewed changes

src/Components/benchmarkapps/Wasm.Performance/dockerfile Outdated Show resolved Hide resolved

dougbu added 2 commits November 9, 2022 21:16

!fixup! Update a yarn.lock file

fa6879b

!fixup! Fix typo in ChromeDriver Java version

3b4c76f

BrennanConroy added 4 commits November 21, 2022 09:01

Update SeleniumStandaloneServer.cs

cf61719

crazy

1a81a40

cool

f735e5e

Update components-e2e-tests.yml

0156df5

MackinnonBuck added 3 commits November 23, 2022 11:32

Merge branch 'main' into safia/update-selenium

b1b1a76

Update selenium standalone version

6450d75

Regenerate remaining yarn.lock files

48b1535

BrennanConroy reviewed Nov 24, 2022

View reviewed changes

SteveSandersonMS force-pushed the safia/update-selenium branch 2 times, most recently from 5049ba0 to 48b1535 Compare November 25, 2022 09:26

SteveSandersonMS mentioned this pull request Nov 25, 2022

Run Selenium tests on Playwright via an adapter [experiment] #45284

Closed

TanayParikh added 5 commits December 14, 2022 15:27

Bump to 108 & 4.7

ae7d751

Revert selenium-standalone NPM package bump

6080a0c

Bump benchmarks docker image to Chrome 108

f4fd290

Bump chrome driver to 108

19fdf2f

Revert selenium standalone upgrade part 2

09f8176

Update yarn.lock

1b0481a

Update SeleniumStandaloneServer.cs

5624bc7

Revert "crazy"

9a52f99

This reverts commit 1a81a40.

Update EventTest.cs

6bb12eb

TanayParikh added 2 commits December 15, 2022 13:35

Revert URL changes

c8dc23a

Update blazor.server.js

093dd75

TanayParikh enabled auto-merge (squash) December 15, 2022 22:20

TanayParikh merged commit 9c25786 into main Dec 15, 2022

TanayParikh deleted the safia/update-selenium branch December 15, 2022 23:14

ghost added this to the 8.0-preview1 milestone Dec 15, 2022

BrennanConroy mentioned this pull request May 17, 2023

Bump selenium-standalone to 8.3.0 - allow E2E testing on osx-arm64 #48288

Closed

BrennanConroy mentioned this pull request Aug 4, 2023

Selenium updates are broken #49869

Closed

github-actions bot locked and limited conversation to collaborators Dec 8, 2023

Update selenium dependency versions #44834

Update selenium dependency versions #44834

Uh oh!

Conversation

captainsafia commented Nov 2, 2022

Uh oh!

captainsafia commented Nov 2, 2022

Uh oh!

azure-pipelines bot commented Nov 2, 2022

Uh oh!

dougbu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dougbu commented Nov 2, 2022

Uh oh!

azure-pipelines bot commented Nov 2, 2022

Uh oh!

captainsafia commented Nov 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dougbu commented Nov 3, 2022

Uh oh!

javiercn commented Nov 3, 2022

Uh oh!

dougbu commented Nov 3, 2022

Uh oh!

dougbu commented Nov 3, 2022

Uh oh!

javiercn commented Nov 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dougbu commented Nov 3, 2022

Uh oh!

dougbu commented Nov 7, 2022

Uh oh!

javiercn commented Nov 7, 2022

Uh oh!

dougbu commented Nov 19, 2022

Uh oh!

BrennanConroy commented Nov 21, 2022

Uh oh!

BrennanConroy Nov 24, 2022

Choose a reason for hiding this comment

Uh oh!

TanayParikh commented Dec 14, 2022

Uh oh!

TanayParikh commented Dec 14, 2022

Uh oh!

TanayParikh commented Dec 15, 2022

Uh oh!

azure-pipelines bot commented Dec 15, 2022

Uh oh!

TanayParikh commented Dec 15, 2022

Uh oh!

TanayParikh commented Dec 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TanayParikh commented Dec 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BrennanConroy commented Dec 15, 2022

Uh oh!

TanayParikh commented Dec 15, 2022

Uh oh!

TanayParikh commented Dec 15, 2022

Uh oh!

sebastienros commented Dec 15, 2022

Uh oh!

Uh oh!

captainsafia commented Nov 3, 2022 •

edited

Loading

javiercn commented Nov 3, 2022 •

edited

Loading

TanayParikh commented Dec 15, 2022 •

edited

Loading

TanayParikh commented Dec 15, 2022 •

edited

Loading