Skip to content

Quarantine WriteAsJsonAsync_AsyncEnumerable_ClosedConnecton #45557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tratcher opened this issue Dec 12, 2022 · 0 comments
Closed

Quarantine WriteAsJsonAsync_AsyncEnumerable_ClosedConnecton #45557

Tratcher opened this issue Dec 12, 2022 · 0 comments
Assignees
@Tratcher
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions test-failure test-fixed
Milestone
Test failures

Comments

@Tratcher
Copy link
Member

Tratcher commented Dec 12, 2022 •
edited
Loading

Tracking dotnet/runtime#79556, there's a regression where the CancellationToken isn't being passed to the IAsyncEnumerable.

Failing Test(s)

Microsoft.AspNetCore.Http.Extensions.Tests.HttpResponseJsonExtensionsTests
WriteAsJsonAsync_AsyncEnumerable_ClosedConnecton
WriteAsJsonAsync_AsyncEnumerable_UserPassedTokenThrows
WriteAsJsonAsyncGeneric_AsyncEnumerable_ClosedConnecton
WriteAsJsonAsyncGeneric_AsyncEnumerable_UserPassedTokenThrows

Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatterTest
WriteResponseBodyAsync_AsyncEnumerableConnectionCloses

Microsoft.AspNetCore.Mvc.Infrastructure.JsonResultExecutorTestBase
ExecuteAsync_AsyncEnumerableConnectionCloses
ExecuteAsyncWithDifferentContentType_AsyncEnumerableConnectionCloses

Error Message

  Message: 
Assert.False() Failure
Expected: False
Actual:   True

Stacktrace


  Stack Trace: 
HttpResponseJsonExtensionsTests.WriteAsJsonAsyncGeneric_AsyncEnumerableG_UserPassedTokenThrows() line 426
--- End of stack trace from previous location ---

Logs

Build

https://dev.azure.com/dnceng-public/public/_build/results?buildId=109479&view=ms.vss-test-web.build-test-results-tab&runId=2337376&resultId=105425&paneView=debug
@Tratcher Tratcher added test-failure blocked The work on this issue is blocked due to some dependency area-runtime labels Dec 12, 2022
Tratcher added a commit that referenced this issue Dec 12, 2022
@Tratcher
Quarantine regressed WriteAsJsonAsync tests #45557
a7359c5
Tratcher added a commit that referenced this issue Dec 12, 2022
@Tratcher
Quarantine regressed async Json test #45557
803c38d
Tratcher added a commit that referenced this issue Dec 12, 2022
@Tratcher
Quarantine regressed async Json test #45557
728307f
@amcasey amcasey added this to the Test failures milestone Dec 12, 2022
@Tratcher Tratcher added test-fixed and removed blocked The work on this issue is blocked due to some dependency labels Dec 14, 2022
dotnet-maestro bot added a commit that referenced this issue Dec 15, 2022
@dotnet-maestro
[main] Update dependencies from dotnet/efcore dotnet/runtime (#45475)
867ffcc 
[main] Update dependencies from dotnet/efcore dotnet/runtime


 - Update templatestrings.json files

 - Update template.json files

 - Update other references to net7

 - Rename publicApi folders

 - Fix RepoTasks

 - Fix it more fixily

 - Really fix it for real this time

 - Undo PreviewFeatures changes

 - Using

 - Merge branch 'darc-main-8caa276f-464b-4e95-a7fa-bc264a536653' of https://github.com/dotnet/aspnetcore into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653

 - Tasks

 - IO

 - CTS

 - Net70

 - Merge branch 'darc-main-8caa276f-464b-4e95-a7fa-bc264a536653' of https://github.com/dotnet/aspnetcore into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653

 - Try using net8.0 for HelixTestRunner

 - Try making ReferenceAssemblies

 - Merge branch 'darc-main-8caa276f-464b-4e95-a7fa-bc264a536653' of https://github.com/dotnet/aspnetcore into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653

 - Get analyzer tests working

 - Ok fine

 - Update doc

 - Path combine

 - Try somethin wacky

 - Fix

 - Using

 - Merge remote-tracking branch 'upstream/main' into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653

 - Quarantine regressed WriteAsJsonAsync tests #45557

 - Quarantine regressed async Json test #45557

 - Re-order DataAnnotationsMetadataProviderTest expected results

 - Quarantine regressed async Json test #45557

 - Re-order DataAnnotationsMetadataProviderTest expected results

 - Merge remote-tracking branch 'upstream/main' into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653

 - Bump E2E timeout to 2 hours

Per discussion in #44834 (comment)

 - React to enum ordering change

 - Merge remote-tracking branch 'upstream/darc-main-8caa276f-464b-4e95-a7fa-bc264a536653' into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653

 - Skip a microbenchmark, update a version

 - Make test resilient to order changes

 - Unquar tests

 - remove custom loader for .wasm file (#45611)
@ghost ghost locked as resolved and limited conversation to collaborators Jan 13, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tratcher Tratcher

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions test-failure test-fixed
Projects
None yet
Milestone
Test failures
Development

No branches or pull requests
2 participants
@Tratcher @amcasey