Skip to content

Suppress false-positives in credential scanning #4392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2018
Merged

Suppress false-positives in credential scanning #4392

merged 1 commit into from
Dec 4, 2018

Conversation

natemcmaster
Copy link
Contributor

@natemcmaster natemcmaster requested a review from Eilon December 4, 2018 18:28
@natemcmaster
Copy link
Contributor Author

@Eilon PTAL to make sure you're okay with these kinds of suppressions

Eilon
Eilon approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These passwords look pretty fake to me.

@natemcmaster natemcmaster merged commit ab12c70 into dotnet:release/2.1 Dec 4, 2018
@natemcmaster natemcmaster deleted the namc/suppress branch December 4, 2018 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Eilon Eilon Eilon approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natemcmaster @Eilon