Cache effective policy in endpoint metadata #43124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
reviewed
Aug 5, 2022
src/Security/Authorization/Core/src/AuthorizationPolicyCache.cs
Outdated
Show resolved
Hide resolved
Kahbazi
reviewed
Aug 6, 2022
src/Security/Authorization/Core/src/AuthorizationPolicyCache.cs
Outdated
Show resolved
Hide resolved
src/Security/Authorization/Core/src/AuthorizationPolicyCache.cs
Outdated
Show resolved
Hide resolved
src/Security/Authorization/Policy/src/AuthorizationEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
HaoK
added
the
api-suggestion
davidfowl
reviewed
Aug 10, 2022
src/Security/Authorization/Policy/src/AuthorizationMiddleware.cs
Outdated
Show resolved
Hide resolved
Kahbazi
reviewed
Aug 11, 2022
src/Security/Authorization/Policy/src/AuthorizationEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
|
I'll send out an email API review for this now |
HaoK
added
api-ready-for-review
|
Thank you for your API proposal. I'm removing the |
ghost
removed
the
api-ready-for-review
HaoK
added
the
api-suggestion
|
Updated to WithAuthorizationPolicyCache and IVT for the metadata per #43227 |
Kahbazi
reviewed
Aug 12, 2022
| /// <returns>The original convention builder parameter.</returns> | ||
| public static TBuilder WithAuthorizationCache<TBuilder>(this TBuilder builder) where TBuilder : IEndpointConventionBuilder | ||
| { | ||
| builder.Add(endpointBuilder => |
There was a problem hiding this comment.
How about to only add AuthorizationPolicyCache if there are IAuthorizeData or AuthorizationPolicy is available in the metadata. Also the new Finally method could be used instead of Add.
…ventionBuilderExtensions.cs Co-authored-by: Kahbazi <[email protected]>
Co-authored-by: David Fowler <[email protected]>
davidfowl
reviewed
Aug 15, 2022
src/Security/Authorization/Policy/src/AuthorizationMiddleware.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Aug 15, 2022
src/Security/Authorization/Policy/src/AuthorizationMiddleware.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Aug 15, 2022
| // Cache the computed policy | ||
| if (policy != null && canCachePolicy) | ||
| { | ||
| _policyCache!.Value![endpoint!] = policy; |
There was a problem hiding this comment.
Yeah the cache code is very excited!!!
davidfowl
reviewed
Aug 15, 2022
src/Security/Authorization/Core/src/DefaultAuthorizationPolicyProvider.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Aug 15, 2022
src/Security/Authorization/Policy/src/AuthorizationMiddleware.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Aug 15, 2022
src/Security/Authorization/Policy/src/AuthorizationMiddleware.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Aug 15, 2022
src/Security/Authorization/Policy/src/AuthorizationMiddleware.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Aug 15, 2022
src/Security/Authorization/Policy/src/AuthorizationPolicyCache.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Aug 15, 2022
|
|
||
| public void Store(Endpoint endpoint, AuthorizationPolicy policy) | ||
| { | ||
| _policyCache!.Value![endpoint!] = policy; |
There was a problem hiding this comment.
No more null checks!
Suggested change
| _policyCache!.Value![endpoint!] = policy; | |
| _policyCache.Value[endpoint] = policy; |
There was a problem hiding this comment.
Value can still be null I think or at least vs says so
davidfowl
reviewed
Aug 15, 2022
src/Security/Authorization/Policy/src/AuthorizationPolicyCache.cs
Outdated
Show resolved
Hide resolved
JamesNK
reviewed
Aug 15, 2022
src/Security/Authorization/Policy/src/AuthorizationPolicyCache.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Aug 15, 2022
src/Security/Authorization/Policy/src/AuthorizationPolicyCache.cs
Outdated
Show resolved
Hide resolved
JamesNK
reviewed
Aug 15, 2022
src/Security/Authorization/Policy/src/AuthorizationPolicyCache.cs
Outdated
Show resolved
Hide resolved
JamesNK
reviewed
Aug 15, 2022
src/Security/Authorization/Policy/src/AuthorizationPolicyCache.cs
Outdated
Show resolved
Hide resolved
JamesNK
reviewed
Aug 15, 2022
src/Security/Authorization/test/AuthorizationEndpointConventionBuilderExtensionsTests.cs
Outdated
Show resolved
Hide resolved
JamesNK
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perf followup to #39840
This adds a metadata cache so we cache the computed policies per endpoint
Fixes #43227