Skip to content

Add comment about RequestQuery #42978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2022
Merged

Add comment about RequestQuery #42978

merged 3 commits into from
Aug 1, 2022

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jul 28, 2022

Adds more information to resolve #42807

@wtgodbe wtgodbe requested a review from adityamandaleeka July 28, 2022 22:39
@ghost ghost added the area-runtime label Jul 28, 2022
@wtgodbe wtgodbe merged commit 54a0dd8 into main Aug 1, 2022
@wtgodbe wtgodbe deleted the wtgodbe/RequestQuery branch August 1, 2022 20:49
@ghost ghost added this to the 7.0-rc1 milestone Aug 1, 2022
/// <remarks>
/// The HTTP Request <see cref="HttpRequest.QueryString"/> is not included with this flag as it may contain private information.
/// If desired, it should be explicitly specified with <see cref="RequestQuery"/>.
/// </remarks>
Request = RequestPropertiesAndHeaders | RequestBody,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this comment get added to RequestProperties as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When the logging fields is all, the request query is not logging
5 participants