Skip to content

Commit 54a0dd8

Browse files
Add comment about RequestQuery (#42978)
* Add comment about RequestQuery * Update src/Middleware/HttpLogging/src/HttpLoggingFields.cs Co-authored-by: Aditya Mandaleeka <[email protected]> * Update HttpLoggingFields.cs Co-authored-by: Aditya Mandaleeka <[email protected]>
1 parent 0de139f commit 54a0dd8

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/Middleware/HttpLogging/src/HttpLoggingFields.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,10 @@ public enum HttpLoggingFields : long
158158
/// Logging the request body has performance implications, as it requires buffering
159159
/// the entire request body up to <see cref="HttpLoggingOptions.RequestBodyLogLimit"/>.
160160
/// </summary>
161+
/// <remarks>
162+
/// The HTTP Request <see cref="HttpRequest.QueryString"/> is not included with this flag as it may contain private information.
163+
/// If desired, it should be explicitly specified with <see cref="RequestQuery"/>.
164+
/// </remarks>
161165
Request = RequestPropertiesAndHeaders | RequestBody,
162166

163167
/// <summary>
@@ -175,5 +179,9 @@ public enum HttpLoggingFields : long
175179
/// the entire request and response body up to the <see cref="HttpLoggingOptions.RequestBodyLogLimit"/>
176180
/// and <see cref="HttpLoggingOptions.ResponseBodyLogLimit"/>.
177181
/// </summary>
182+
/// <remarks>
183+
/// The HTTP Request <see cref="HttpRequest.QueryString"/> is not included with this flag as it may contain private information.
184+
/// If desired, it should be explicitly specified with <see cref="RequestQuery"/>.
185+
/// </remarks>
178186
All = Request | Response
179187
}

0 commit comments

Comments
 (0)