[SignalR] Pass cancellation token to FlushAsync #41180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
reviewed
Apr 13, 2022
src/SignalR/clients/csharp/Client/test/UnitTests/HubConnectionTests.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
Apr 13, 2022
src/SignalR/clients/csharp/Client/test/UnitTests/HubConnectionTests.cs
Outdated
Show resolved
Hide resolved
halter73
approved these changes
Apr 14, 2022
ghost
added this to the
This was referenced Feb 24, 2023
Merged
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40475
The token wasn't being passed in because of a bug in Pipelines see original change aspnet/SignalR#1718 (comment)
The bug was fixed a day after the PR was merged and we never reacted 🤣
dotnet/runtime#25633
For full transparency, this doesn't mean the written Hub message wont be sent to the server. It only means the user has decided they don't want to wait any longer on any backpressure applied by the Pipe. For invokes it also means the client will ignore any CompletionMessage for the canceled invokes (but this isn't new).