Skip to content

Adding a new ActionResult to process IResult #40710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Mar 23, 2022
Merged

Adding a new ActionResult to process IResult #40710

merged 22 commits into from
Mar 23, 2022

Conversation

brunolins16
Copy link
Member

@brunolins16 brunolins16 commented Mar 15, 2022 •
edited
Loading

Related PR #40639

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 15, 2022
@davidfowl
Copy link
Member

Can you add a test with a filter?

pranavkm
pranavkm reviewed Mar 16, 2022
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should also include tests for ApiExplorer since that's also being updated.

@pranavkm
Copy link
Contributor

Consider filing a follow up issue to make Mvc.Api.Analyzer support this. As it stands, it'll treat returned IResult instances as ok-results. Relevant code: https://github.com/dotnet/aspnetcore/blob/main/src/Mvc/Mvc.Api.Analyzers/src/ActualApiResponseMetadataFactory.cs

@brunolins16 brunolins16 marked this pull request as ready for review March 21, 2022 19:58
@brunolins16 brunolins16 requested a review from a team as a code owner March 21, 2022 19:58
BrennanConroy
BrennanConroy reviewed Mar 22, 2022
View reviewed changes
@brunolins16 brunolins16 mentioned this pull request Mar 22, 2022
Open
@brunolins16 brunolins16 enabled auto-merge (squash) March 23, 2022 22:13
@brunolins16 brunolins16 linked an issue Mar 23, 2022 that may be closed by this pull request
IResult support in MVC #40639
Closed
@brunolins16 brunolins16 removed a link to an issue Mar 23, 2022
IResult support in MVC #40639
Closed
@brunolins16 brunolins16 merged commit bc96b3e into dotnet:main Mar 23, 2022
@ghost ghost added this to the 7.0-preview3 milestone Mar 23, 2022
@brunolins16 brunolins16 linked an issue Mar 24, 2022 that may be closed by this pull request
IResult support in MVC #40639
Closed
@brunolins16 brunolins16 deleted the brunolins16/issues/40639 branch March 24, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm pranavkm left review comments

@BrennanConroy BrennanConroy BrennanConroy left review comments

@halter73 halter73 halter73 approved these changes

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
7.0-preview4
Development

Successfully merging this pull request may close these issues.

IResult support in MVC
5 participants
@brunolins16 @davidfowl @pranavkm @halter73 @BrennanConroy