Skip to content

Add nullable annotations to Identity.Extensions #40007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

pranavkm
Copy link
Contributor

@pranavkm pranavkm commented Feb 5, 2022

No description provided.

@pranavkm pranavkm requested a review from Pilchie as a code owner February 5, 2022 01:57
@ghost ghost added the area-identity Includes: Identity and providers label Feb 5, 2022
@pranavkm pranavkm requested review from HaoK and Tratcher February 5, 2022 01:58
@pranavkm
Copy link
Contributor Author

pranavkm commented Feb 5, 2022

@HaoK / @Tratcher I'm very unfamiliar with this code, but the way I went about annotating this was looking at the results from the EF implementation and using that to model the interface. Outside of a couple of weird ones (like normalizing Id producing null because we call ToString() this seemed straightforward. Once we resolve the shape, I'll remove the NoWarn and update the PublicApi analyzer files.

@Tratcher Tratcher removed their request for review February 7, 2022 18:22
Copy link
Contributor Author

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I"ll fixup the tests soonish

@pranavkm pranavkm merged commit 05b2afb into dotnet:main Feb 10, 2022
@pranavkm pranavkm deleted the nullable-identity branch February 10, 2022 23:44
@ghost ghost added this to the 7.0-preview2 milestone Feb 10, 2022
@luizfbicalho
Copy link

why UserName and Role.Name are Nullable? I think tha this open the model to much more problems and needs more validation

@ghost
Copy link

ghost commented Oct 12, 2022

Hi @luizfbicalho. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

smfeest added a commit to smfeest/buttercup that referenced this pull request Mar 4, 2023
Nullable annotations have been added to
Microsoft.Extensions.Identity.Core [1] in .NET 7, necessitating these
changes to avoid CS8604 and CS8634 compiler warnings on upgrading.

[1] dotnet/aspnetcore#40007
smfeest added a commit to smfeest/buttercup that referenced this pull request Mar 4, 2023
Nullable annotations have been added to
Microsoft.Extensions.Identity.Core [1] in .NET 7, necessitating these
changes to avoid CS8604 and CS8634 compiler warnings on upgrading.

[1] dotnet/aspnetcore#40007
smfeest added a commit to smfeest/buttercup that referenced this pull request Mar 5, 2023
Nullable annotations have been added to
Microsoft.Extensions.Identity.Core [1] in .NET 7, necessitating these
changes to avoid CS8604 and CS8634 compiler warnings on upgrading.

[1] dotnet/aspnetcore#40007
smfeest added a commit to smfeest/buttercup that referenced this pull request Mar 5, 2023
Nullable annotations have been added to
Microsoft.Extensions.Identity.Core [1] in .NET 7, necessitating these
changes to avoid CS8604 and CS8634 compiler warnings on upgrading.

[1] dotnet/aspnetcore#40007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-identity Includes: Identity and providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants