-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add nullable annotations to Identity.Extensions #40007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@HaoK / @Tratcher I'm very unfamiliar with this code, but the way I went about annotating this was looking at the results from the EF implementation and using that to model the interface. Outside of a couple of weird ones (like normalizing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I"ll fixup the tests soonish
ad07d51
to
878b417
Compare
873a8ee
to
8a662c0
Compare
why UserName and Role.Name are Nullable? I think tha this open the model to much more problems and needs more validation |
Hi @luizfbicalho. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Nullable annotations have been added to Microsoft.Extensions.Identity.Core [1] in .NET 7, necessitating these changes to avoid CS8604 and CS8634 compiler warnings on upgrading. [1] dotnet/aspnetcore#40007
Nullable annotations have been added to Microsoft.Extensions.Identity.Core [1] in .NET 7, necessitating these changes to avoid CS8604 and CS8634 compiler warnings on upgrading. [1] dotnet/aspnetcore#40007
Nullable annotations have been added to Microsoft.Extensions.Identity.Core [1] in .NET 7, necessitating these changes to avoid CS8604 and CS8634 compiler warnings on upgrading. [1] dotnet/aspnetcore#40007
Nullable annotations have been added to Microsoft.Extensions.Identity.Core [1] in .NET 7, necessitating these changes to avoid CS8604 and CS8634 compiler warnings on upgrading. [1] dotnet/aspnetcore#40007
No description provided.