Avoid changing schema

Author: pranavkm

src/Identity/EntityFrameworkCore/src/Microsoft.AspNetCore.Identity.EntityFrameworkCore.csproj

@@ -5,8 +5,6 @@
     <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <PackageTags>aspnetcore;entityframeworkcore;identity;membership</PackageTags>
-    <NoWarn>$(NoWarn);RS0036</NoWarn>
-
   </PropertyGroup>
 
   <ItemGroup>

src/Identity/EntityFrameworkCore/src/PublicAPI.Unshipped.txt

@@ -220,7 +220,7 @@ protected virtual async Task SaveChanges(CancellationToken cancellationToken)
     /// <param name="role">The role whose name should be returned.</param>
     /// <param name="cancellationToken">The <see cref="CancellationToken"/> used to propagate notifications that the operation should be canceled.</param>
     /// <returns>A <see cref="Task{TResult}"/> that contains the name of the role.</returns>
-    public virtual Task<string> GetRoleNameAsync(TRole role, CancellationToken cancellationToken = default(CancellationToken))
+    public virtual Task<string?> GetRoleNameAsync(TRole role, CancellationToken cancellationToken = default(CancellationToken))
     {
         cancellationToken.ThrowIfCancellationRequested();
         ThrowIfDisposed();
@@ -238,7 +238,7 @@ protected virtual async Task SaveChanges(CancellationToken cancellationToken)
     /// <param name="roleName">The name of the role.</param>
     /// <param name="cancellationToken">The <see cref="CancellationToken"/> used to propagate notifications that the operation should be canceled.</param>
     /// <returns>The <see cref="Task"/> that represents the asynchronous operation.</returns>
-    public virtual Task SetRoleNameAsync(TRole role, string roleName, CancellationToken cancellationToken = default(CancellationToken))
+    public virtual Task SetRoleNameAsync(TRole role, string? roleName, CancellationToken cancellationToken = default(CancellationToken))
     {
         cancellationToken.ThrowIfCancellationRequested();
         ThrowIfDisposed();
@@ -311,7 +311,7 @@ protected virtual async Task SaveChanges(CancellationToken cancellationToken)
     /// <param name="role">The role whose normalized name should be retrieved.</param>
     /// <param name="cancellationToken">The <see cref="CancellationToken"/> used to propagate notifications that the operation should be canceled.</param>
     /// <returns>A <see cref="Task{TResult}"/> that contains the name of the role.</returns>
-    public virtual Task<string> GetNormalizedRoleNameAsync(TRole role, CancellationToken cancellationToken = default(CancellationToken))
+    public virtual Task<string?> GetNormalizedRoleNameAsync(TRole role, CancellationToken cancellationToken = default(CancellationToken))
     {
         cancellationToken.ThrowIfCancellationRequested();
         ThrowIfDisposed();
@@ -329,7 +329,7 @@ protected virtual async Task SaveChanges(CancellationToken cancellationToken)
     /// <param name="normalizedName">The normalized name to set</param>
     /// <param name="cancellationToken">The <see cref="CancellationToken"/> used to propagate notifications that the operation should be canceled.</param>
     /// <returns>The <see cref="Task"/> that represents the asynchronous operation.</returns>
-    public virtual Task SetNormalizedRoleNameAsync(TRole role, string normalizedName, CancellationToken cancellationToken = default(CancellationToken))
+    public virtual Task SetNormalizedRoleNameAsync(TRole role, string? normalizedName, CancellationToken cancellationToken = default(CancellationToken))
     {
         cancellationToken.ThrowIfCancellationRequested();
         ThrowIfDisposed();
@@ -371,7 +371,7 @@ protected void ThrowIfDisposed()
             throw new ArgumentNullException(nameof(role));
         }
 
-        return await RoleClaims.Where(rc => rc.RoleId.Equals(role.Id)).Select(c => new Claim(c.ClaimType, c.ClaimValue)).ToListAsync(cancellationToken);
+        return await RoleClaims.Where(rc => rc.RoleId.Equals(role.Id)).Select(c => new Claim(c.ClaimType!, c.ClaimValue!)).ToListAsync(cancellationToken);
     }
 
     /// <summary>

src/Identity/EntityFrameworkCore/src/RoleStore.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System;
+using System.Diagnostics;
 
 namespace Microsoft.AspNetCore.Identity;
 
@@ -30,8 +31,9 @@ public DefaultPersonalDataProtector(ILookupProtectorKeyRing keyRing, ILookupProt
     /// </summary>
     /// <param name="data">The data to unprotect.</param>
     /// <returns>The unprotected data.</returns>
-    public virtual string Unprotect(string data)
+    public virtual string? Unprotect(string? data)
     {
+        Debug.Assert(data != null);
         var split = data.IndexOf(':');
         if (split == -1 || split == data.Length - 1)
         {
@@ -47,7 +49,7 @@ public virtual string Unprotect(string data)
     /// </summary>
     /// <param name="data">The data to protect.</param>
     /// <returns>The protected data.</returns>
-    public virtual string Protect(string data)
+    public virtual string? Protect(string? data)
     {
         var current = _keyRing.CurrentKeyId;
         return current + ":" + _encryptor.Protect(current, data);

src/Identity/Extensions.Core/src/DefaultPersonalDataProtector.cs

@@ -1,6 +1,8 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using System.Diagnostics.CodeAnalysis;
+
 namespace Microsoft.AspNetCore.Identity;
 
 /// <summary>
@@ -14,13 +16,15 @@ public interface ILookupProtector
     /// <param name="keyId">The key to use.</param>
     /// <param name="data">The data to protect.</param>
     /// <returns>The protected data.</returns>
-    string Protect(string keyId, string data);
+    [return: NotNullIfNotNull("data")]
+    string? Protect(string keyId, string? data);
 
     /// <summary>
     /// Unprotect the data using the specified key.
     /// </summary>
     /// <param name="keyId">The key to use.</param>
     /// <param name="data">The data to unprotect.</param>
     /// <returns>The original data.</returns>
-    string Unprotect(string keyId, string data);
+    [return: NotNullIfNotNull("data")]
+    string? Unprotect(string keyId, string? data);
 }

src/Identity/Extensions.Core/src/ILookupProtector.cs

@@ -1,6 +1,8 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using System.Diagnostics.CodeAnalysis;
+
 namespace Microsoft.AspNetCore.Identity;
 
 /// <summary>
@@ -13,12 +15,14 @@ public interface IPersonalDataProtector
     /// </summary>
     /// <param name="data">The data to protect.</param>
     /// <returns>The protected data.</returns>
-    string Protect(string data);
+    [return: NotNullIfNotNull("data")]
+    string? Protect(string? data);
 
     /// <summary>
     /// Unprotect the data.
     /// </summary>
     /// <param name="data"></param>
     /// <returns>The unprotected data.</returns>
-    string Unprotect(string data);
+    [return: NotNullIfNotNull("data")]
+    string? Unprotect(string? data);
 }

src/Identity/Extensions.Core/src/IPersonalDataProtector.cs

@@ -51,7 +51,7 @@ public interface IRoleStore<TRole> : IDisposable where TRole : class
     /// <param name="role">The role whose name should be returned.</param>
     /// <param name="cancellationToken">The <see cref="CancellationToken"/> used to propagate notifications that the operation should be canceled.</param>
     /// <returns>A <see cref="Task{TResult}"/> that contains the name of the role.</returns>
-    Task<string> GetRoleNameAsync(TRole role, CancellationToken cancellationToken);
+    Task<string?> GetRoleNameAsync(TRole role, CancellationToken cancellationToken);
 
     /// <summary>
     /// Sets the name of a role in the store as an asynchronous operation.
@@ -60,15 +60,15 @@ public interface IRoleStore<TRole> : IDisposable where TRole : class
     /// <param name="roleName">The name of the role.</param>
     /// <param name="cancellationToken">The <see cref="CancellationToken"/> used to propagate notifications that the operation should be canceled.</param>
     /// <returns>The <see cref="Task"/> that represents the asynchronous operation.</returns>
-    Task SetRoleNameAsync(TRole role, string roleName, CancellationToken cancellationToken);
+    Task SetRoleNameAsync(TRole role, string? roleName, CancellationToken cancellationToken);
 
     /// <summary>
     /// Get a role's normalized name as an asynchronous operation.
     /// </summary>
     /// <param name="role">The role whose normalized name should be retrieved.</param>
     /// <param name="cancellationToken">The <see cref="CancellationToken"/> used to propagate notifications that the operation should be canceled.</param>
     /// <returns>A <see cref="Task{TResult}"/> that contains the name of the role.</returns>
-    Task<string> GetNormalizedRoleNameAsync(TRole role, CancellationToken cancellationToken);
+    Task<string?> GetNormalizedRoleNameAsync(TRole role, CancellationToken cancellationToken);
 
     /// <summary>
     /// Set a role's normalized name as an asynchronous operation.
@@ -77,7 +77,7 @@ public interface IRoleStore<TRole> : IDisposable where TRole : class
     /// <param name="normalizedName">The normalized name to set</param>
     /// <param name="cancellationToken">The <see cref="CancellationToken"/> used to propagate notifications that the operation should be canceled.</param>
     /// <returns>The <see cref="Task"/> that represents the asynchronous operation.</returns>
-    Task SetNormalizedRoleNameAsync(TRole role, string normalizedName, CancellationToken cancellationToken);
+    Task SetNormalizedRoleNameAsync(TRole role, string? normalizedName, CancellationToken cancellationToken);
 
     /// <summary>
     /// Finds the role who has the specified ID as an asynchronous operation.

src/Identity/Extensions.Core/src/IRoleStore.cs

@@ -21,7 +21,7 @@ public interface IUserAuthenticationTokenStore<TUser> : IUserStore<TUser> where
     /// <param name="value">The value of the token.</param>
     /// <param name="cancellationToken">The <see cref="CancellationToken"/> used to propagate notifications that the operation should be canceled.</param>
     /// <returns>The <see cref="Task"/> that represents the asynchronous operation.</returns>
-    Task SetTokenAsync(TUser user, string loginProvider, string name, string value, CancellationToken cancellationToken);
+    Task SetTokenAsync(TUser user, string loginProvider, string name, string? value, CancellationToken cancellationToken);
 
     /// <summary>
     /// Deletes a token for a user.

src/Identity/Extensions.Core/src/IUserAuthenticationTokenStore.cs

@@ -27,7 +27,7 @@ public interface IUserStore<TUser> : IDisposable where TUser : class
     /// <param name="user">The user whose name should be retrieved.</param>
     /// <param name="cancellationToken">The <see cref="CancellationToken"/> used to propagate notifications that the operation should be canceled.</param>
     /// <returns>The <see cref="Task"/> that represents the asynchronous operation, containing the name for the specified <paramref name="user"/>.</returns>
-    Task<string> GetUserNameAsync(TUser user, CancellationToken cancellationToken);
+    Task<string?> GetUserNameAsync(TUser user, CancellationToken cancellationToken);
 
     /// <summary>
     /// Sets the given <paramref name="userName" /> for the specified <paramref name="user"/>.
@@ -36,15 +36,15 @@ public interface IUserStore<TUser> : IDisposable where TUser : class
     /// <param name="userName">The user name to set.</param>
     /// <param name="cancellationToken">The <see cref="CancellationToken"/> used to propagate notifications that the operation should be canceled.</param>
     /// <returns>The <see cref="Task"/> that represents the asynchronous operation.</returns>
-    Task SetUserNameAsync(TUser user, string userName, CancellationToken cancellationToken);
+    Task SetUserNameAsync(TUser user, string? userName, CancellationToken cancellationToken);
 
     /// <summary>
     /// Gets the normalized user name for the specified <paramref name="user"/>.
     /// </summary>
     /// <param name="user">The user whose normalized name should be retrieved.</param>
     /// <param name="cancellationToken">The <see cref="CancellationToken"/> used to propagate notifications that the operation should be canceled.</param>
     /// <returns>The <see cref="Task"/> that represents the asynchronous operation, containing the normalized user name for the specified <paramref name="user"/>.</returns>
-    Task<string> GetNormalizedUserNameAsync(TUser user, CancellationToken cancellationToken);
+    Task<string?> GetNormalizedUserNameAsync(TUser user, CancellationToken cancellationToken);
 
     /// <summary>
     /// Sets the given normalized name for the specified <paramref name="user"/>.
@@ -53,7 +53,7 @@ public interface IUserStore<TUser> : IDisposable where TUser : class
     /// <param name="normalizedName">The normalized name to set.</param>
     /// <param name="cancellationToken">The <see cref="CancellationToken"/> used to propagate notifications that the operation should be canceled.</param>
     /// <returns>The <see cref="Task"/> that represents the asynchronous operation.</returns>
-    Task SetNormalizedUserNameAsync(TUser user, string normalizedName, CancellationToken cancellationToken);
+    Task SetNormalizedUserNameAsync(TUser user, string? normalizedName, CancellationToken cancellationToken);
 
     /// <summary>
     /// Creates the specified <paramref name="user"/> in the user store.

src/Identity/Extensions.Core/src/IUserStore.cs

@@ -96,7 +96,7 @@ public virtual IdentityError LoginAlreadyAssociated()
     /// </summary>
     /// <param name="userName">The user name that is invalid.</param>
     /// <returns>An <see cref="IdentityError"/> indicating the specified user <paramref name="userName"/> is invalid.</returns>
-    public virtual IdentityError InvalidUserName(string userName)
+    public virtual IdentityError InvalidUserName(string? userName)
     {
         return new IdentityError
         {
@@ -152,7 +152,7 @@ public virtual IdentityError DuplicateEmail(string email)
     /// </summary>
     /// <param name="role">The invalid role.</param>
     /// <returns>An <see cref="IdentityError"/> indicating the specific role <paramref name="role"/> name is invalid.</returns>
-    public virtual IdentityError InvalidRoleName(string role)
+    public virtual IdentityError InvalidRoleName(string? role)
     {
         return new IdentityError
         {