Skip to content

Fix LogError argument order in WebAssemblyErrorBoundaryLogger #39223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ internal sealed class WebAssemblyErrorBoundaryLogger : IErrorBoundaryLogger

public WebAssemblyErrorBoundaryLogger(ILogger<ErrorBoundary> errorBoundaryLogger)
{
_errorBoundaryLogger = errorBoundaryLogger ?? throw new ArgumentNullException(nameof(errorBoundaryLogger)); ;
_errorBoundaryLogger = errorBoundaryLogger ?? throw new ArgumentNullException(nameof(errorBoundaryLogger));
}

public ValueTask LogErrorAsync(Exception exception)
{
// For, client-side code, all internal state is visible to the end user. We can just
// log directly to the console.
_errorBoundaryLogger.LogError(exception.ToString(), exception);
_errorBoundaryLogger.LogError(exception, exception.ToString());
return ValueTask.CompletedTask;
}
}