Skip to content

Include the exception when logging in WebAssemblyErrorBoundaryLogger #39202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2021
Merged

Include the exception when logging in WebAssemblyErrorBoundaryLogger #39202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/Components/WebAssembly/WebAssembly/src/Services/WebAssemblyErrorBoundaryLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Components.Web;
using Microsoft.Extensions.Logging;

namespace Microsoft.AspNetCore.Components.WebAssembly.Services;

internal class WebAssemblyErrorBoundaryLogger : IErrorBoundaryLogger
internal sealed class WebAssemblyErrorBoundaryLogger : IErrorBoundaryLogger
{
private readonly ILogger<ErrorBoundary> _errorBoundaryLogger;

Expand All @@ -21,7 +19,7 @@ public ValueTask LogErrorAsync(Exception exception)
{
// For, client-side code, all internal state is visible to the end user. We can just
// log directly to the console.
_errorBoundaryLogger.LogError(exception.ToString());
_errorBoundaryLogger.LogError(exception.ToString(), exception);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is wrong, as the exception comes before the message. See #39223

return ValueTask.CompletedTask;
}
}