Include the exception when logging in WebAssemblyErrorBoundaryLogger #39202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
TanayParikh
approved these changes
Dec 27, 2021
campersau
reviewed
Dec 29, 2021
| @@ -21,7 +19,7 @@ public ValueTask LogErrorAsync(Exception exception) | |||
| { | |||
| // For, client-side code, all internal state is visible to the end user. We can just | |||
| // log directly to the console. | |||
| _errorBoundaryLogger.LogError(exception.ToString()); | |||
| _errorBoundaryLogger.LogError(exception.ToString(), exception); | |||
There was a problem hiding this comment.
I think this is wrong, as the exception comes before the message. See #39223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39039