Skip to content

Fix Kestrel psuedo header reuse #38585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 23, 2021
Merged

Fix Kestrel psuedo header reuse #38585

merged 3 commits into from
Nov 23, 2021

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Nov 23, 2021

Fixes #38581

@JamesNK JamesNK requested a review from wtgodbe November 23, 2021 01:50
@JamesNK
Copy link
Member Author

JamesNK commented Nov 23, 2021

FYI @adityamandaleeka

halter73
halter73 reviewed Nov 23, 2021
View reviewed changes
@sebastienros
Copy link
Member

Is psuedo a thing or did you mean pseudo ?

JamesNK
JamesNK commented Nov 23, 2021
View reviewed changes
@JamesNK JamesNK merged commit 6893565 into main Nov 23, 2021
@JamesNK JamesNK deleted the jamesnk/psuedo-header-reuse branch November 23, 2021 21:09
@ghost ghost added this to the 7.0-preview1 milestone Nov 23, 2021
@martincostello martincostello mentioned this pull request Feb 19, 2022
Closed
1 task
@davidfowl davidfowl added Perf and removed Perf labels Sep 30, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 left review comments

@Tratcher Tratcher Tratcher approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@wtgodbe wtgodbe Awaiting requested review from wtgodbe

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
7.0-preview1
Development

Successfully merging this pull request may close these issues.

Pseudo header string reuse broken in .NET 6
6 participants
@JamesNK @sebastienros @halter73 @Tratcher @davidfowl @amcasey