HTTP/3: Remove AsTask allocations #38559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
BrennanConroy,
halter73 and
Tratcher
as code owners
JamesNK
commented
Nov 21, 2021
Comment on lines
-82
to
-91
| #pragma warning disable CS8634 // The type cannot be used as type parameter in the generic type or method. Nullability of type argument doesn't match 'class' constraint. | ||
| _applicationServiceCollection.AddSingleton(services | ||
| => services.GetService<ApplicationLifetime>() as IHostApplicationLifetime); | ||
| _applicationServiceCollection.AddSingleton<IHostApplicationLifetime>(services | ||
| => services.GetService<ApplicationLifetime>()!); | ||
| #pragma warning disable CS0618 // Type or member is obsolete | ||
| _applicationServiceCollection.AddSingleton(services | ||
| => services.GetService<ApplicationLifetime>() as AspNetCore.Hosting.IApplicationLifetime); | ||
| _applicationServiceCollection.AddSingleton(services | ||
| => services.GetService<ApplicationLifetime>() as Extensions.Hosting.IApplicationLifetime); | ||
| _applicationServiceCollection.AddSingleton<AspNetCore.Hosting.IApplicationLifetime>(services | ||
| => services.GetService<ApplicationLifetime>()!); | ||
| _applicationServiceCollection.AddSingleton<Extensions.Hosting.IApplicationLifetime>(services | ||
| => services.GetService<ApplicationLifetime>()!); | ||
| #pragma warning restore CS0618 // Type or member is obsolete | ||
| #pragma warning restore CS8634 // The type cannot be used as type parameter in the generic type or method. Nullability of type argument doesn't match 'class' constraint. |
There was a problem hiding this comment.
Was compiling on my machine because of nullability changes.
Explain? https://source.dot.net/#System.Private.CoreLib/ValueTask.cs,866c24d850fbd0c7 |
|
|
wtgodbe
approved these changes
Nov 22, 2021
Tratcher
approved these changes
Nov 22, 2021
ghost
added this to the
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsTaskalways allocates. Use existingGetAsTaskto avoid allocation if task is already complete.