Fix multiple dictionary add in polly #37533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
HaoK
reviewed
Oct 13, 2021
src/HttpClientFactory/Polly/test/PolicyHttpMessageHandlerTest.cs
Outdated
Show resolved
Hide resolved
HaoK
approved these changes
Oct 13, 2021
Tratcher
commented
Oct 13, 2021
src/HttpClientFactory/Polly/test/PolicyHttpMessageHandlerTest.cs
Outdated
Show resolved
Hide resolved
adityamandaleeka
approved these changes
Oct 13, 2021
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1339596313 |
10 tasks
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 6.0-rc2 customer feedback 8d5212d#r57959949
#36162 previously fixed an issue with undisposed responses when retrying requests. Unfortunately, it introduced a regression if you have multiple policies, throwing a duplicate dictionary key exception for the second policy.
The fix is to use the dictionary indexer instead of Add. The disposal logic is idempotent, it doesn't matter if it runs multiple times.
This needs to be backported to 6.0.