Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 6, 2021

Backport of #37317 to release/6.0

Fixes #37290

Required for ARM64 work.

@github-actions github-actions bot requested a review from a team as a code owner October 6, 2021 16:31
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 6, 2021
@ericstj ericstj changed the title [release/6.0] [main] Update WiX to signed build [release/6.0] Update WiX to build 5722 Oct 6, 2021
@ericstj ericstj requested review from joeloff, wtgodbe and dougbu October 6, 2021 16:34
@TanayParikh
Copy link
Contributor

CI passing, @wtgodbe, @dougbu is this fine to merge or does it need to go through tactics?

@ericstj
Copy link
Member

ericstj commented Oct 6, 2021

This is a tell-mode change to tactics. That email has been sent. 👍

Copy link
Contributor

@TanayParikh TanayParikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as it is a back port.

@TanayParikh TanayParikh merged commit 5d63645 into release/6.0 Oct 6, 2021
@TanayParikh TanayParikh deleted the backport/pr-37317-to-release/6.0 branch October 6, 2021 18:22
@ghost ghost added this to the 6.0.0 milestone Oct 6, 2021
ericstj added a commit to ericstj/aspnetcore that referenced this pull request Oct 8, 2021
ericstj added a commit to ericstj/aspnetcore that referenced this pull request Oct 8, 2021
dougbu added a commit that referenced this pull request Oct 11, 2021
* [release/6.0-rc2] Retarget DOTNETHOME when installing x64 on ARM64 (#36695)

* Retarget DOTNETHOME when installing x64 on ARM64

* Make platform comparison case insenstive

* Address feedback

* Install x64 registry keys to different path on ARM64 machine

Co-authored-by: Eric StJohn <[email protected]>

* Update WiX to signed build (#36865)

- #12078

* Update wix to 1.0.0-v3.14.0.5722 (#37329)

Co-authored-by: Eric StJohn <[email protected]>

* [release/6.0] Use WIX_NATIVE_MACHINE to detect native architecture of target machine (#37335)

* Use WIX_NATIVE_MACHINE to detect native architecture of target machine
* Reference WIX_NATIVE_MACHINE property

Final bit to resolve what I'm tracking in #37290

Co-authored-by: Eric StJohn <[email protected]>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Doug Bunting <[email protected]>
dougbu added a commit that referenced this pull request Oct 11, 2021
* [release/6.0-rc2] Retarget DOTNETHOME when installing x64 on ARM64 (#36695)

* Retarget DOTNETHOME when installing x64 on ARM64

* Make platform comparison case insenstive

* Address feedback

* Install x64 registry keys to different path on ARM64 machine

Co-authored-by: Eric StJohn <[email protected]>

* Update WiX to signed build (#36865)

- #12078

* Update wix to 1.0.0-v3.14.0.5722 (#37329)

Co-authored-by: Eric StJohn <[email protected]>

* [release/6.0] Use WIX_NATIVE_MACHINE to detect native architecture of target machine (#37335)

* Use WIX_NATIVE_MACHINE to detect native architecture of target machine
* Reference WIX_NATIVE_MACHINE property

Final bit to resolve what I'm tracking in #37290

Co-authored-by: Eric StJohn <[email protected]>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Doug Bunting <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants