Skip to content

[release/2.1] Include SharedFx bundle in Hosting Bundle, instead of SharedFx .msi #36890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 2, 2021
Merged

[release/2.1] Include SharedFx bundle in Hosting Bundle, instead of SharedFx .msi #36890

merged 3 commits into from
Nov 2, 2021

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Sep 23, 2021

Backport of #36858

@wtgodbe wtgodbe requested review from joeloff and a team September 23, 2021 17:22
@wtgodbe wtgodbe requested a review from Pilchie as a code owner September 23, 2021 17:22
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 23, 2021
@dougbu
Copy link
Contributor

dougbu commented Sep 24, 2021

Please ping when you get this working 😉

@wtgodbe
Copy link
Member Author

wtgodbe commented Sep 24, 2021

Please ping when you get this working 😉

The failures are unrelated, they were on NPM and Kestrel tests on Linux/Mac - this only touches the Windows installers

@wtgodbe
Copy link
Member Author

wtgodbe commented Sep 24, 2021

Test internal build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1384206&view=results

@wtgodbe
Copy link
Member Author

wtgodbe commented Sep 24, 2021 •
edited
Loading

New build https://dev.azure.com/dnceng/internal/_build/results?buildId=1385037&view=results

@wtgodbe
Copy link
Member Author

wtgodbe commented Sep 24, 2021

Test build worked

@wtgodbe wtgodbe merged commit 7ba36b2 into release/2.1 Nov 2, 2021
@wtgodbe wtgodbe deleted the wtgodbe/BundleChain21 branch November 2, 2021 17:06
@dougbu dougbu added this to the 2.1.31 milestone Nov 2, 2021
@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeloff joeloff joeloff approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
2.1.31
Development

Successfully merging this pull request may close these issues.
3 participants
@wtgodbe @dougbu @joeloff