Avoid using invalid content type for ValidationProblemDetails #36617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
added
the
old-area-web-frameworks-do-not-use
|
/backport to release/6.0-rc2 |
|
Started backporting to release/6.0-rc2: https://github.com/dotnet/aspnetcore/actions/runs/1242932944 |
10 tasks
halter73
approved these changes
Sep 16, 2021
pranavkm
reviewed
Sep 16, 2021
| /// <returns>A <see cref="DelegateEndpointConventionBuilder"/> that can be used to further customize the endpoint.</returns> | ||
| public static DelegateEndpointConventionBuilder ProducesValidationProblem(this DelegateEndpointConventionBuilder builder, | ||
| int statusCode = StatusCodes.Status400BadRequest, | ||
| string? contentType = null) | ||
| { | ||
| if (string.IsNullOrEmpty(contentType)) | ||
| { | ||
| contentType = "application/validationproblem+json"; | ||
| contentType = "application/problem+json"; |
There was a problem hiding this comment.
Is MVC also affected by this? Could we also fix it while we're addressing this?
There was a problem hiding this comment.
AFAICT, MVC isn't affected by this. The ControllerBase.ValidationProblem method uses the application/problem+json content type and the ProducesResponseType attribute expects that users pass the content type for when they specify a typeof(ValidationProblemDetails) hence the fix for the test case below.
BrennanConroy
approved these changes
Sep 16, 2021
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36560
Closes #36557.
The OpenAPI extension methods assume an
application/validationproblem+jsoncontent type but the results object represnet a different result.