Skip to content

Update http3 RequiresPreviewFeatures attributes with message/URL #36491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

adityamandaleeka
Copy link
Member

Fixes #36450

Keeping in draft while we confirm this actually works "for real" in VS. It doesn't work yet with the current SDK.

@ghost ghost added the area-runtime label Sep 14, 2021
@adityamandaleeka
Copy link
Member Author

@pgovind Is this feature ready for use?

@pgovind
Copy link

pgovind commented Sep 14, 2021

Is this feature ready for use?

.NET 6 is not going to support showing a message/URL in the analyzer diagnostic. All diagnostic currently point to aka.ms/dotnet-warnings/preview-features. We just didn't have enough time to bake that into RC2. The analyzer itself will be turned on with a severity of Error by default in RC2 though. As a workaround, we could consider adding some blurbs specific to Http3 at aka.ms/dotnet-warnings/preview-features when it comes online?

cc @jeffhandley

@adityamandaleeka
Copy link
Member Author

Thanks @pgovind. So if we were to merge this now, the feature would light up at some point in the future?

I don't have a strong preference on whether we need to include http3-specific messaging on the general "what are preview features" link, though it may be interesting to have a page for each release going forward that has a list of features that are considered preview in that release, and to point to that from the general preview features link.

@adityamandaleeka
Copy link
Member Author

@pgovind Can you confirm if this is correct:

So if we were to merge this now, the feature would light up at some point in the future?

@pgovind
Copy link

pgovind commented Sep 27, 2021

So if we were to merge this now, the feature would light up at some point in the future?

Apologies, I missed the notification for the previous comment. Indeed, this will light up in the future as soon as dotnet/roslyn-analyzers#5502 is merged and the bits flow everywhere.

@adityamandaleeka adityamandaleeka marked this pull request as ready for review September 27, 2021 22:04
@adityamandaleeka adityamandaleeka merged commit 69a594e into dotnet:main Sep 27, 2021
@ghost ghost added this to the 7.0-preview1 milestone Sep 27, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP/3: Improve the preview features warning message.
5 participants