[release/2.1] Honor sliding expiration in the security stamp validator #36480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
changed the title
Tratcher
added
the
Servicing-consider
|
"Hi github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
github-actions
bot
requested review from
a team and
Tratcher
as code owners
adityamandaleeka
approved these changes
Sep 13, 2021
There was a problem hiding this comment.
LGTM. @wtgodbe can you review to make sure the patch config is right and we didn't miss something?
blowdart
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #36469 to release/2.1
/cc @Tratcher
Description
SecurityStampValidator may override SlidingExpiration and extend the auth session lifetime longer than desired.
Regression?
No
Testing
Unit and manual.
Risk
Low