Skip to content

Remove WebView path/query code that isn't used anymore #36354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

Eilon
Copy link
Contributor

@Eilon Eilon commented Sep 9, 2021

This is internal code that wasn't referenced anywhere.

@Eilon Eilon requested a review from a team as a code owner September 9, 2021 23:10
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Sep 9, 2021
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this was likely required because of the old static web assets manifest provider

@javiercn
Copy link
Member

@Eilon the normal process now is to check-in on main first and then cherry-pick to release/6.0.

I don't mind if we merge this right away and you cherry-pick to main, just keep in mind that for future reference.

@dotnet/aspnet-build can you merge when possible?

@wtgodbe wtgodbe merged commit 12a1969 into release/6.0 Sep 10, 2021
@wtgodbe wtgodbe deleted the eilon/remove-unused-path-apis branch September 10, 2021 16:09
@ghost ghost added this to the 6.0-rc2 milestone Sep 10, 2021
@Eilon
Copy link
Contributor Author

Eilon commented Sep 10, 2021

I'll try to get it right next time! I opened #36377 for copying the commit to main.

@ghost
Copy link

ghost commented Sep 10, 2021

Hi @Eilon. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants