HTTP/3: Fix incorrectly pooling aborted streams #35434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
added
area-runtime
tell-mode
JamesNK
requested review from
BrennanConroy,
halter73 and
Tratcher
as code owners
JamesNK
commented
Aug 18, 2021
| @@ -514,6 +514,69 @@ public async Task GET_MultipleRequestsInSequence_ReusedState() | |||
| } | |||
| } | |||
|
|
|||
| [ConditionalFact] | |||
| [MsQuicSupported] | |||
| public async Task StreamResponseContent_DelayAndTrailers_ClientSuccess() | |||
There was a problem hiding this comment.
Un-related unit test. IMO no harm in adding it. These tests are all quarantined.
src/Servers/Kestrel/Transport.Quic/src/Internal/QuicStreamContext.cs
Outdated
Show resolved
Hide resolved
adityamandaleeka
approved these changes
Aug 18, 2021
Tratcher
approved these changes
Aug 18, 2021
Tratcher
reviewed
Aug 18, 2021
| @@ -115,8 +115,7 @@ public async Task ClientCertificate_Required_NotSent_ConnectionAborted() | |||
|
|
|||
| // https://github.com/dotnet/runtime/issues/57246 The accept still completes even though the connection was rejected, but it's already failed. | |||
| var serverContext = await connectionListener.AcceptAndAddFeatureAsync().DefaultTimeout(); | |||
| qex = await Assert.ThrowsAsync<QuicException>(() => serverContext.ConnectAsync().DefaultTimeout()); | |||
| Assert.Equal("Failed to open stream to peer. Error Code: INVALID_STATE", qex.Message); | |||
| await Assert.ThrowsAsync<QuicException>(() => serverContext.ConnectAsync().DefaultTimeout()); | |||
There was a problem hiding this comment.
I don't remember exactly. It was something like "Stream creation error BLAH BLAH BLAH" 😄
JamesNK
force-pushed
the
jamesnk/http3-quicstream-pooling-fix
branch
from
2cce478 to
667fc58
Compare
JamesNK
removed
the
tell-mode
JamesNK
force-pushed
the
jamesnk/http3-quicstream-pooling-fix
branch
from
667fc58 to
e244296
Compare
ghost
added this to the 
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/runtime#57608