Skip to content

Adapted test case to set Authority to an http address #35361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

benedikt257
Copy link
Contributor

Adapted test case to set Authority to an http address

ThrowsWhenAuthorityIsNotHttps in OpenIdConnectConfigurationTests now sets the Autority property instead of MetadataAddress.

PR Description

As outlined in issue #35219, the implementation of the test case is not in sync with the naming of the test. This PR attempts to address this. As far as I can tell, there is nothing more to this than this simple change with which the test evaluates a slighly different code path appending a default path to the Authority when (only) it is set.

Fixes #35219

@benedikt257 benedikt257 requested a review from Tratcher as a code owner August 15, 2021 19:38
@ghost ghost added area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer community-contribution Indicates that the PR has been added by a community member labels Aug 15, 2021
@Tratcher Tratcher merged commit 5393e1f into dotnet:main Aug 16, 2021
@ghost ghost added this to the 6.0-rc1 milestone Aug 16, 2021
@Tratcher
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test does not set Authority, while name suggests otherwise
2 participants