HTTP/3: QUIC connection listener fixes #35258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
BrennanConroy,
halter73 and
Tratcher
as code owners
|
Quic should be checking for equivalence, not constant instances. Wouldn't you get the same issue if someone passes in |
Tratcher
reviewed
Aug 11, 2021
halter73
reviewed
Aug 11, 2021
halter73
reviewed
Aug 11, 2021
|
I thought of a better fix that solves this (until fixed in system.net.quic) for all binding/configuration types. |
Tratcher
reviewed
Aug 11, 2021
| @@ -35,8 +35,21 @@ public QuicConnectionListener(QuicTransportOptions options, IQuicTrace log, EndP | |||
| _context = new QuicTransportContext(_log, options); | |||
| var quicListenerOptions = new QuicListenerOptions(); | |||
|
|
|||
| var listenEndPoint = (IPEndPoint)endpoint; | |||
There was a problem hiding this comment.
Lol, you half-fixed #35200. Want to add the real exception now or wait?
halter73
approved these changes
Aug 11, 2021
Tratcher
reviewed
Aug 12, 2021
| @@ -49,7 +49,7 @@ public async Task BindAsync_NoServerCertificate_Error() | |||
| var ex = await Assert.ThrowsAsync<InvalidOperationException>(() => quicTransportFactory.BindAsync(new IPEndPoint(0, 0), features: features, cancellationToken: CancellationToken.None).AsTask()).DefaultTimeout(); | |||
|
|
|||
| // Assert | |||
| Assert.Equal("SslServerAuthenticationOptions.ServerCertificate must be configured with a value.", ex.Message); | |||
| Assert.Equal("SslServerAuthenticationOptions must provide a server certificate using ServerCertificate, ServerCertificateContext, or ServerCertificateSelectionCallback.", ex.Message); | |||
There was a problem hiding this comment.
Thanks, I missed this test in my last change.
JamesNK
changed the title
ghost
added this to the
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListenAnyIP passes an
EndPointwith an address ofIPAddress.IPv6Anyto the transports. If there are multiple transports, i.e. TCP and multiplexed QUIC, then the address value was being replaced with an address that looks like IPv6Any, but isn't theIPAddress.IPv6Anyconstant.QuicConnectionListenerhas logic that checks for this constant.Now the original address of a listener is always passed unchanged to each transport. The overall endpoint can be updated by the first transport when an ephemeral port (port 0) is bound. We want to share that.