Improve Minimal APIs support for request media types #35082

[rafikiassumani-msft]

Improve Minimal APIs support for request media types

PR Description
Refactoring code to prepare for changes that are needed to enable accepts media types for Minimal APIs

Fixes #35082

[pranavkm]

Speaking to @halter73, the plan was for RequestDelegateFactory to return an IReadOnlyList<object> which will get added as endpoint metadata by the caller. Here's what I propose the API would look like:

public static RequestDelegateResult Create(MethodInfo methodInfo, Func<HttpContext, object>? targetFactory = null, RequestDelegateFactoryOptions? options = null)

where

public sealed class RequestDelegateResult
{
   public RequestDelegate RequestDelegate { get; }

   public IReadOnlyList<object> EndpointMetadata { get; }
}

[halter73]

What's the behavior now? Is the MediaType just "" or something? Or is the collection empty? Let's just add a regression test for whatever we think the behavior should be in this case rather than delete the test.

[rafikiassumani-msft]

/backport to release/6.0-rc1

[github-actions]

Started backporting to release/6.0-rc1: https://github.com/dotnet/aspnetcore/actions/runs/1152357480

[github-actions]

@rafikiassumanimsft backporting to release/6.0-rc1 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: add support for request media types
Applying: change namespace for acceptsmatcher policy
Applying: additional changes
Using index info to reconstruct a base tree...
M	src/Http/Http.Extensions/src/RequestDelegateFactory.cs
M	src/Http/Routing/src/Builder/MinimalActionEndpointRouteBuilderExtensions.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Http/Routing/src/Builder/MinimalActionEndpointRouteBuilderExtensions.cs
Auto-merging src/Http/Http.Extensions/src/RequestDelegateFactory.cs
CONFLICT (content): Merge conflict in src/Http/Http.Extensions/src/RequestDelegateFactory.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 additional changes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

[rachna-lad]

@rafikiassumani-msft How does Accepts work when Content-Type in Header is null?
I have defined Accepts("application/json") as supported content type.

[ghost]

Hi @rachna-lad. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.