Make HubConnection methods virtual #35132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kahbazi
reviewed
Aug 7, 2021
| @@ -233,7 +233,7 @@ public HubConnection(IConnectionFactory connectionFactory, IHubProtocol protocol | |||
| /// </summary> | |||
| /// <param name="cancellationToken">The token to monitor for cancellation requests. The default value is <see cref="CancellationToken.None" />.</param> | |||
| /// <returns>A <see cref="Task"/> that represents the asynchronous start.</returns> | |||
| public async Task StartAsync(CancellationToken cancellationToken = default) | |||
| public virtual async Task StartAsync(CancellationToken cancellationToken = default) | |||
| { | |||
| CheckDisposed(); | |||
| using (_logger.BeginScope(_logScope)) | |||
There was a problem hiding this comment.
The logs in the override method won't have the log scope. Is it important?
How about adding new virtual methods which are already wrapped in the log scope?
public async Task StartAsync(CancellationToken cancellationToken = default)
{
using (_logger.BeginScope(_logScope))
{
await NewMethodStartAsync(cancellationToken);
}
}
public virtual async Task NewMethodStartAsync(CancellationToken cancellationToken = default)
{
CheckDisposed();
await StartAsyncInner(cancellationToken).ForceAsync();
}
There was a problem hiding this comment.
I think this is to much ceremony for what we're trying to achieve. This is about testability, not about being able to put custom code into our logging scopes. If you want to create an outer scope for your override, you can still do that.
halter73
approved these changes
Aug 9, 2021
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34843