Make "builder.Services" reflect the final state of the ServiceCollection #34455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Some systems capture the ServiceCollection as a service in order to build child containers. This change updates the ServiceCollection on build to reflect the final state of services so that new containers built are accurate. - Added tests
ghost
added
the
davidfowl
added
feature-minimal-actions
davidfowl
changed the title
captainsafia
approved these changes
Jul 17, 2021
amcasey
added
area-minimal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IServiceCollectionas a service in order to build child containers. This change updates theIServiceCollectionon build to reflect the final state of services so that new containers built are accurate.Fixes #34210