Skip to content

Make "builder.Services" reflect the final state of the ServiceCollection #34455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

davidfowl
Copy link
Member

@davidfowl davidfowl commented Jul 17, 2021

  • Some systems capture the IServiceCollection as a service in order to build child containers. This change updates the IServiceCollection on build to reflect the final state of services so that new containers built are accurate.
  • Added tests

Fixes #34210

- Some systems capture the ServiceCollection as a service in order to build child containers. This change updates the ServiceCollection on build to reflect the final state of services so that new containers built are accurate.
- Added tests
@davidfowl davidfowl requested a review from Tratcher as a code owner July 17, 2021 07:07
@ghost ghost added the area-runtime label Jul 17, 2021
@davidfowl davidfowl added feature-minimal-actions Controller-like actions for endpoint routing feature-minimal-hosting and removed feature-minimal-actions Controller-like actions for endpoint routing labels Jul 17, 2021
@davidfowl davidfowl changed the title Make "builder.Services" reflect the final set of services Make "builder.Services" reflect the final state of the ServiceCollection Jul 17, 2021
@davidfowl davidfowl merged commit a104e2d into main Jul 19, 2021
@davidfowl davidfowl deleted the davidfowl/make-service-collection-accurate branch July 19, 2021 21:10
@ghost ghost added this to the 6.0-rc1 milestone Jul 19, 2021
@amcasey amcasey added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-minimal-hosting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimal code pattern doesn't work with OrchardCore in net6.0
3 participants