-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Update to bootstrap5 #34052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to bootstrap5 #34052
Conversation
Things look green on the ci side, can folks take a look at the templates to make sure they look reasonable visually? @danroth27 @SteveSandersonMS @blowdart @pranavkm @javiercn There are a few templates here: https://github.com/HaoK/Random/tree/boot5/Templates I didn't do a full set if there are any other ones you'd like me to generate let me know |
...Web.ProjectTemplates/content/BlazorServerWeb-CSharp/Shared/NavMenu.CallsMicrosoftGraph.razor
Outdated
Show resolved
Hide resolved
...rojectTemplates/Web.ProjectTemplates/content/BlazorServerWeb-CSharp/Shared/NavMenu.razor.css
Outdated
Show resolved
Hide resolved
@bradygaster here's the output of some of the templates from this PR here: https://github.com/HaoK/Random/tree/boot5/Templates I rebased today off main so it might require very current bits to actually run, I see errors due to a new head component in the razor. The MVC variant templates run though |
@blowdart can you take a look at these templates with bootstrap 5 as well, review the individual auth variant in particular https://github.com/HaoK/Random/tree/boot5/Templates/mvcIndAuth |
Current look at post confirmation/logged on screen: changes look to be the hello/log out are squished to left, and also the confirm email alert is visible after upgrade to bootstrap 5 cc @blowdart Comparison picture for main templates today |
That also appears to be squished upwards too, that confirm button for example is right under the text box, rather than under a slight gap. |
Continuation of #33592
Output of this PR's templates will be found here: https://github.com/HaoK/Random/tree/boot5/Templates