Skip to content

Update to bootstrap5 #34052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 52 commits into from
Aug 4, 2021
Merged

Update to bootstrap5 #34052

merged 52 commits into from
Aug 4, 2021

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Jul 3, 2021

Continuation of #33592

Output of this PR's templates will be found here: https://github.com/HaoK/Random/tree/boot5/Templates

@HaoK HaoK mentioned this pull request Jul 6, 2021
@HaoK HaoK force-pushed the haok/bootstrap5 branch from 4c40087 to 8bcec40 Compare July 12, 2021 18:04
@Pilchie Pilchie added area-identity Includes: Identity and providers area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Jul 15, 2021
@HaoK HaoK force-pushed the haok/bootstrap5 branch from 7a1a0ca to 8d85058 Compare July 19, 2021 19:56
@HaoK
Copy link
Member Author

HaoK commented Jul 19, 2021

Things look green on the ci side, can folks take a look at the templates to make sure they look reasonable visually? @danroth27 @SteveSandersonMS @blowdart @pranavkm @javiercn

There are a few templates here: https://github.com/HaoK/Random/tree/boot5/Templates I didn't do a full set if there are any other ones you'd like me to generate let me know

@HaoK HaoK requested a review from a team July 19, 2021 23:15
@HaoK HaoK marked this pull request as ready for review July 19, 2021 23:15
@HaoK HaoK requested a review from Pilchie as a code owner July 19, 2021 23:15
@danroth27
Copy link
Member

Top row in the Blazor templates should be full width. Right now it looks like this:

image

@danroth27
Copy link
Member

Hamburger menu should be in the upper right on small screens. Currently it drops to the lower left and is cut off:

image

@danroth27
Copy link
Member

An outline shows up around the heading when I first run the app:
image

@HaoK HaoK force-pushed the haok/bootstrap5 branch from 312502d to 415c1ad Compare July 26, 2021 17:07
@HaoK
Copy link
Member Author

HaoK commented Jul 27, 2021

@bradygaster here's the output of some of the templates from this PR here: https://github.com/HaoK/Random/tree/boot5/Templates I rebased today off main so it might require very current bits to actually run, I see errors due to a new head component in the razor. The MVC variant templates run though

@HaoK
Copy link
Member Author

HaoK commented Jul 27, 2021

New Issue with the confirm email alert always showing up with bootstrap 5:

image

@HaoK
Copy link
Member Author

HaoK commented Jul 27, 2021

@blowdart can you take a look at these templates with bootstrap 5 as well, review the individual auth variant in particular https://github.com/HaoK/Random/tree/boot5/Templates/mvcIndAuth

@HaoK HaoK force-pushed the haok/bootstrap5 branch from 350180d to 07ad97b Compare August 2, 2021 18:39
@HaoK HaoK force-pushed the haok/bootstrap5 branch from 07ad97b to f7ba454 Compare August 2, 2021 18:41
@HaoK
Copy link
Member Author

HaoK commented Aug 2, 2021

Current look at post confirmation/logged on screen: changes look to be the hello/log out are squished to left, and also the confirm email alert is visible after upgrade to bootstrap 5 cc @blowdart

image

Comparison picture for main templates today

image

@blowdart
Copy link
Contributor

blowdart commented Aug 2, 2021

That also appears to be squished upwards too, that confirm button for example is right under the text box, rather than under a slight gap.

@HaoK HaoK merged commit 709038b into main Aug 4, 2021
@HaoK HaoK deleted the haok/bootstrap5 branch August 4, 2021 16:16
@ghost ghost added this to the 6.0-rc1 milestone Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-identity Includes: Identity and providers area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants