-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Bootstrap5 #33592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap5 #33592
Conversation
|
||
using Microsoft.AspNetCore.Mvc.RazorPages; | ||
|
||
namespace Microsoft.AspNetCore.Identity.UI.V4.Pages.Account.Internal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might want to change these to be V5 namespaces right @javiercn or will this change so it doesn't matter?
Looking forwards to seeing this in action, @Mryam1! One tricky thing about our project template infrastructure is that it's very difficult to get a runnable project from the source code, which complicates the review. Do you have some way of executing these updated templates to get an example of the output project? I totally understand if not, but if it's possible to make a small repo somewhere containing examples of the emitted projects (that are runnable) that would be extremely beneficial. |
|
Could @Mryam1 publish the generated projects from scripts directory to a GitHub repo? Might be quicker than having to build the project. |
Merged this branch and continuing this PR in #34052 still working through the issues around identity UI, but I was able to generate current outputs of the templates which don't use auth which can be reviewed already: |
Replaced by #34052 |
Updated Templates to bootstrap5
Summary of the changes (Less than 80 chars)