Skip to content

Bootstrap5 #33592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Bootstrap5 #33592

wants to merge 3 commits into from

Conversation

Mryam1
Copy link

@Mryam1 Mryam1 commented Jun 17, 2021

Updated Templates to bootstrap5

Summary of the changes (Less than 80 chars)

  • Updated the web templates to use the latest version of bootstrap.

@Mryam1 Mryam1 requested review from Pilchie and a team as code owners June 17, 2021 01:10
@dnfadmin
Copy link

dnfadmin commented Jun 17, 2021

CLA assistant check
All CLA requirements met.


using Microsoft.AspNetCore.Mvc.RazorPages;

namespace Microsoft.AspNetCore.Identity.UI.V4.Pages.Account.Internal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might want to change these to be V5 namespaces right @javiercn or will this change so it doesn't matter?

@SteveSandersonMS
Copy link
Member

Looking forwards to seeing this in action, @Mryam1!

One tricky thing about our project template infrastructure is that it's very difficult to get a runnable project from the source code, which complicates the review. Do you have some way of executing these updated templates to get an example of the output project? I totally understand if not, but if it's possible to make a small repo somewhere containing examples of the emitted projects (that are runnable) that would be extremely beneficial.

@LadyNaggaga
Copy link

LadyNaggaga commented Jun 17, 2021

Do you have some way of executing these updated templates to get an example of the output project?
@SteveSandersonMS Mryam tested each template locally with the template with the project template scripts and will respond to this PR with a few screenshots. She noticed that she couldn't test the Identity UI locally. We tried passing the -au Individual in the scripts, and we get a bunch of errors.

@pranavkm
Copy link
Contributor

Could @Mryam1 publish the generated projects from scripts directory to a GitHub repo? Might be quicker than having to build the project.

@Mryam1
Copy link
Author

Mryam1 commented Jun 17, 2021

Here is a screenshot of the webapp template running locally with bootstrap5.

image

Could @Mryam1 publish the generated projects from scripts directory to a GitHub repo? Might be quicker than having to build the project.

What are the steps to doing this? @pranavkm

@Pilchie Pilchie added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 17, 2021
@HaoK HaoK self-assigned this Jul 3, 2021
@HaoK HaoK mentioned this pull request Jul 3, 2021
@HaoK
Copy link
Member

HaoK commented Jul 6, 2021

Merged this branch and continuing this PR in #34052 still working through the issues around identity UI, but I was able to generate current outputs of the templates which don't use auth which can be reviewed already:

https://github.com/HaoK/Random/tree/boot5/Templates

@HaoK
Copy link
Member

HaoK commented Jul 14, 2021

Replaced by #34052

@HaoK HaoK closed this Jul 14, 2021
@dougbu dougbu deleted the bootstrap5 branch August 21, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants