Enable nullable references in project templates #34007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to #33947
ghost
added
the
area-mvc
pranavkm
approved these changes
Jul 1, 2021
5 tasks
jmarolf
approved these changes
Jul 1, 2021
javiercn
reviewed
Jul 2, 2021
| @@ -25,7 +25,8 @@ | |||
| ".template.config/**" | |||
| ], | |||
| "copyOnly": [ | |||
| "wwwroot/**" | |||
| "wwwroot/**", | |||
| "ClientApp/package-lock.json" | |||
There was a problem hiding this comment.
@DamianEdwards can you clarify why you did this?
Is it because of the template engine bug that appeared a few days ago?
I believe the package-lock.json needs to be processed by the template engine, since it contains stuff like Company1.Webapplication that needs to "potentially" match your project name?
I bring this up because @HaoK is investigating an issue, and we are trying to lock down on it.
There was a problem hiding this comment.
Yeah Hao reached out to me. I hit the issue while testing this and made this change at @pranavkm's suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable nullable references in project templates
Contributes to #33947