[release/3.1] Adjust #line directives a bit
#33423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- was "Add option to `RazorPageGenerator` for `#line` preprocessor directives (#27765) (#29024)" - cherry-picked from d546861 in 'release/5.0' branch - was cherry-picked from 1a241fc in 'main' branch - avoid new CS1504 errors because compiler can't find the ErrorPage.cshtml file - problem seems specific to local builds of this branch - no tooling changes because `RazorPageGenerator` is in aspnetcore-tooling for 3.1 - change amounts to running 'release/5.0' or 'main' version of tool in this branch - ErrorPage.cshtml files in three branches were identical at time of previous commits ('main' version of ErrorPage.cshtml recently for nullability)
dougbu
added
the
area-infrastructure
|
Have seen See #29024 for much more background and reasons |
wtgodbe
approved these changes
Jun 10, 2021
|
Yes, tell-mode is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was "Add option to
RazorPageGeneratorfor#linepreprocessor directives (Add option toRazorPageGeneratorfor#linepreprocessor directives #27765) ([release/5.0] Add option toRazorPageGeneratorfor#linepreprocessor directives (#27765) #29024)"cherry-picked from d546861 in 'release/5.0' branch
avoid new CS1504 errors because compiler can't find the ErrorPage.cshtml file
no tooling changes because
RazorPageGeneratoris in aspnetcore-tooling for 3.1change amounts to running 'release/5.0' or 'main' version of tool in this branch
('main' version of ErrorPage.cshtml recently for nullability)