-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Blazor WebView alternate runtime platform #33413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
namespace Microsoft.AspNetCore.Components.WebView.Photino | ||
{ | ||
internal class PhotinoDispatcher : Dispatcher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure yet, but I might be able to eliminate this entirely by using Blazor's built-in "default" dispatcher. Haven't completely figured out whether that aligns with what Photino needs, but TBH I don't mind if we end up keeping this class here.
Since the Photino stuff is just for "testing," should it go into some testing folder instead of Platform? |
(And then it doesn't need to track shipping APIs, etc.?) |
I don’t know. It is a “platform” even though we’re not shipping it. It will be a sample/playground as much as it is for testing. I marked the assemblies as nonshipping - is that sufficient? |
It is nice to not have sample/test code mixed in with production code to make it obvious that this isn't like all the other code, maybe its better in Components/WebView/samples directory that's already there? |
@SteveSandersonMS I don't have a strong sense of what is best, but given that it doesn't ship at all, and is for testing/demo only, to me it seems to fit better in a samples/tests location. |
5bd5345
to
383fef3
Compare
OK, I've moved it under |
@dotnet/aspnet-build The build is failing with:
What's the latest story on adding a new 3rd-party NuGet package? I see we don't reference the public NuGet.org feed any more. I checked the FYI this new package is purely a sample/test dependency and doesn't impact any released code. |
cc @dougbu @wtgodbe about #33413 (comment). Sounds like it has to be added to our feeds. Is this something you're able to do? Thanks! |
@SteveSandersonMS, I don't know if anyone other than @wtgodbe and @mmitche can get Photino.NET into the |
Pushed |
/azp run |
Pull request contains merge conflicts. |
@SteveSandersonMS there might still be a package missing: |
This one is the dependency of Photino.NET: https://www.nuget.org/packages/Photino.Native/ |
pushed |
/azp run |
Pull request contains merge conflicts. |
Makes more of the test cases work properly.
af515bd
to
2af3d10
Compare
src/Components/ComponentsNoDeps.slnf
Outdated
@@ -37,6 +37,16 @@ | |||
"src\\Components\\WebAssembly\\testassets\\Wasm.Authentication.Server\\Wasm.Authentication.Server.csproj", | |||
"src\\Components\\WebAssembly\\testassets\\Wasm.Authentication.Shared\\Wasm.Authentication.Shared.csproj", | |||
"src\\Components\\WebAssembly\\testassets\\WasmLinkerTest\\WasmLinkerTest.csproj", | |||
"src\\Components\\WebView\\Samples\\PhotinoPlatform\\src\\Microsoft.AspNetCore.Components.WebView.Photino.csproj", | |||
"src\\Components\\WebView\\Samples\\PhotinoPlatform\\testassets\\PhotinoTestApp\\PhotinoTestApp.csproj", | |||
"src\\Components\\WebView\\Platforms\\WebView2\\src\\Microsoft.AspNetCore.Components.WebView.WebView2.csproj", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to rebase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted, thanks.
Since @Eilon is moving the WinForms/WPF support out into the MAUI repo, we're going to need some other way to run the Microsoft.AspNetCore.Blazor.WebView code that remains in this repo (and the corresponding
blazor.webview.js
) to make sure it actually works and we can add features to it.This PR adds a new Photino hosting platform which is a bit like the WinForms/WPF hosts except (1) it's cross-platform and can run on macOS/Linux too, and (2) it's limited to purely having a single Blazor webview in a window, and can't have any other native controls alongside it.
There is no plan to ship this for public use. People who actually want that can already use Photino's built-in Blazor support and simply don't need what we have here. The purpose of what we have here is just to help us validate and debug our ongoing work on Microsoft.AspNetCore.Blazor.WebView.