Skip to content

Conversation

DavidKarlas
Copy link
Contributor

Latest dotnet new doesn't work with relative path for --debug:custom-hive... Hence make it absolute
Also switched to using --debug:disable-sdk-templates to avoid potential conflict between SDK and tests installed templates.

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

PR Title
Fixes #32028: Investigate Template Baseline tests errors

PR Description
In dotnet new we recently changed how SDK(and optional workloads) templates are installed... Which made it impossible to uninstall them... Hence we introduced --debug:disable-sdk-templates to make it possible to test SDK templates in this repo...
But it looks like we introduced another regression which is, --debug:custom-hive doesn't support relative path anymore... I already open issue on our repo to fix that, but since propagation of that would take some time, I made change here to use Path.GetFullPath()

Addresses #32028

Latest `dotnet new` doesn't work with relative path for `--debug:custom-hive`... Hence make it absolute
Also switched to using `--debug:disable-sdk-templates` to avoid potential conflict between SDK and tests installed templates.
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 22, 2021
@HaoK
Copy link
Member

HaoK commented Apr 22, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dougbu
Copy link
Contributor

dougbu commented Apr 25, 2021

Many thanks @DavidKarlas.

We no longer need this PR because @halter73 included the fix in 'release/6.0-preview4' as part of 90137b0 / #32003. That merged into main in 12401e7 / #32123.

@dougbu dougbu closed this Apr 25, 2021
@dougbu dougbu deleted the dev/davkar/fixTemplatesTests branch April 25, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate Template Baseline tests errors
3 participants