HTTP/3: Header limits and validation #31928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotalik
reviewed
Apr 19, 2021
| @@ -521,6 +535,15 @@ private Task ProcessUnknownFrameAsync() | |||
| await OnEndStreamReceived(); | |||
| } | |||
|
|
|||
| if (!_isMethodConnect && (_parsedPseudoHeaderFields & _mandatoryRequestPseudoHeaderFields) != _mandatoryRequestPseudoHeaderFields) | |||
| { | |||
| // All HTTP/3 requests MUST include exactly one valid value for the :method, :scheme, and :path pseudo-header | |||
There was a problem hiding this comment.
Is this not a requirement for HTTP/2?
There was a problem hiding this comment.
HTTP/2 and HTTP/3 have the same requirements here.
jkotalik
approved these changes
Apr 19, 2021
ghost
added this to the
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #29702
Also copy tests from HTTP/2.
runtime changes mirrored here - dotnet/runtime#51486