Skip to content

Conversation

@dotnet-maestro-bot
Copy link
Contributor

I detected changes in the release/2.1 branch which have not been merged yet to main. I'm a robot and am configured to help you automatically keep main up to date, so I've opened this PR.

This PR merges commits made on release/2.1 by the following committers:

  • dougbu

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout release/2.1
git pull --ff-only
git checkout main
git pull --ff-only
git merge --no-ff release/2.1

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet-maestro-bot/AspNetCore HEAD:merge/release/2.1-to-main
or if you are using SSH
git push [email protected]:dotnet-maestro-bot/AspNetCore HEAD:merge/release/2.1-to-main

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/2.1-to-main'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.

git checkout -b merge/release/2.1-to-main main
git pull https://github.com/dotnet-maestro-bot/AspNetCore merge/release/2.1-to-main
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet-maestro-bot/AspNetCore HEAD:merge/release/2.1-to-main
or if you are using SSH
git checkout -b merge/release/2.1-to-main main
git pull [email protected]:dotnet-maestro-bot/AspNetCore merge/release/2.1-to-main
(make changes)
git commit -m "Updated PR with my changes"
git push [email protected]:dotnet-maestro-bot/AspNetCore HEAD:merge/release/2.1-to-main

Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.

* Update branding to 2.1.28

* Bump `$(MicrosoftNETCoreAppPackageVersion)`
  - version flows into `$(MicrosoftNETCoreApp21PackageVersion)` automatically
  - cherry-picked from dotnet#30729 internal branch

* Get tests and archives working after rebranding
  - skip `SharedFxTests.BaselineTest(...)` between rebranding and baseline updates
    - previous runtime is not available in this window
  - reduce retries in `RetryHelper`
    - download will usually fail repeatedly if it fails even once
    - previous maximum duration (105 min.) was greater than the job timeout
  - avoid NETSDK1023 warnings
    - eng/targets/CSharp.Common.props adds packages removed from project
  - create archives based on one that actually exists between rebranding and baseline updates
  - mostly cherry-picked from dotnet#30729 internal branch

  nit: remove unused `GetTotalRetriesUsed()` method

* Use Ubuntu 18.04 build agents
  - set locale consistently on all platforms
    - default locale on newer agents is unloved `C.UTF-8`

* Stop using Ubuntu 14.04
  - run `locale-gen` to avoid "setlocale: LC_ALL: cannot change locale" and similar
    - needs `locales` package
  - move to still-supported Ubuntu 18.04 image
    - image needs slightly-newer `libicu60`, `clang` and `lldb` packages
    - rename Dockerfile to match
  - cherry-picked from dotnet#30729 internal branch for Ubuntu image update

  nit: set locale-related environment variables to match Python default

* Avoid KoreBuild issues when using dockerbuild.sh
  - avoid MSB4011 warnings (about repeated Directory.Build.targets imports)
    - place `$DOTNET_HOME` beside repo root, not under it
  - cherry-picked from dotnet#30729 internal branch for image update

  nits:
  - use current Docker image for 2.1 alpine
  - set `$LANGUAGE` with other locale-related environment variables

* Remove obsolete Groovy code

* Pick up latest EF sources
  - minor change shouldn't affect submodule build but best to keep up

* Improve the CDN tests
  - apply efe9b95 to similar template test
  - add debug output to CDN tests
  - back-port test reliability fix
    - based on  @javiercn's 3368ea6 / dotnet#13646 fix
    - avoid `TimeSpan` arithmetic and did not match refactoring done in 'release/3.1'
      - do not have recently-added `TimeSpan` operators in 2.1
  - skip `CdnScriptTaghelperTests` on .NET Framework
    - failures appear specific to that platform
    - leave src/Templating/test/Templates.Test/CdnScriptTagTests.cs unchanged
      - test project does not target .NET Framework
@dotnet-maestro-bot dotnet-maestro-bot requested review from a team, javiercn and pranavkm as code owners April 9, 2021 16:57
@dotnet-maestro-bot dotnet-maestro-bot force-pushed the merge/release/2.1-to-main branch from e57d9e7 to 2c42322 Compare April 9, 2021 16:57
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Merge Forward ⏩ labels Apr 9, 2021
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving branch merge.

@ghost ghost added tell-mode Indicates a PR which is being merged during tell-mode community-contribution Indicates that the PR has been added by a community member labels Apr 9, 2021
@pranavkm pranavkm force-pushed the merge/release/2.1-to-main branch from e934cac to 47f71c6 Compare April 13, 2021 20:58
@pranavkm pranavkm merged commit 9ac1a7a into dotnet:main Apr 14, 2021
@mkArtakMSFT mkArtakMSFT removed the community-contribution Indicates that the PR has been added by a community member label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode Type: Merge Forward ⏩

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants