Skip to content

Added guidance about community contribution PRs #30180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 17, 2021
Merged

Conversation

mkArtakMSFT
Copy link
Contributor

@mkArtakMSFT mkArtakMSFT commented Feb 14, 2021

Updated Contributing code and content section to include information about how to choose issues to contribute to and what process to follow.

This is only a part of the workflow. The next one is to make sure we ask community contributors to follow this guidance when they submit a new issue, which I will handle soon.

Updated `Contributing code and content` section to include information about how to choose issues to contribute to and what process to follow.
@mkArtakMSFT mkArtakMSFT marked this pull request as ready for review February 15, 2021 16:12
@mkArtakMSFT mkArtakMSFT requested a review from a team February 15, 2021 16:12
@mkArtakMSFT mkArtakMSFT added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 15, 2021
Co-authored-by: Javier Calvarro Nelson <[email protected]>
@mkArtakMSFT mkArtakMSFT requested a review from a team February 16, 2021 20:03
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I hope other folks also chime in, since this is a "shared" responsibility.

@mkArtakMSFT mkArtakMSFT requested a review from a team February 16, 2021 20:26
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likes it

Not sure if the GitHub UI is messing things up but the "Within that set," paragraph and the second item in the list are all run together and not clearly part of the same list. Might need to indent the paragraphs a bit more. (I clicked on the Display rich diff option to the left of the Viewed checkbox.)

@mkArtakMSFT
Copy link
Contributor Author

Thanks @dougbu. I've resolved your concern and it shows better now.

@dougbu
Copy link
Contributor

dougbu commented Feb 17, 2021

it shows better now.

It does indeed 👍

@mkArtakMSFT
Copy link
Contributor Author

@BrennanConroy, @Pilchie I'm waiting for your sign-offs. I believe I've addressed your feedback.

@mkArtakMSFT mkArtakMSFT merged commit 2f66d58 into main Feb 17, 2021
@mkArtakMSFT mkArtakMSFT deleted the mkArtakMSFT-patch-1-1 branch February 17, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants