-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Update Blazor Server App template name to BlazorApp
#29764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BlazorApp
BlazorApp
@@ -445,7 +445,7 @@ | |||
"path": "BlazorServerWeb-CSharp.csproj" | |||
} | |||
], | |||
"defaultName": "WebApplication", | |||
"defaultName": "BlazorApp", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't abbreviate things on user displayed strings
"defaultName": "BlazorApp", | |
"defaultName": "BlazorApplication", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danroth27 I'll let you suggest the exact phrase here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
App is not an abbreviation. It is a modern synonym for application. Examples of this usage include "Apple App Store". Use is "app" is preferred over "application" in the Microsoft Style Guide: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/a/app-application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update WebApplication to WebApp to then?
Line 374 in 241b10a
"defaultName": "WebApplication", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was motivated by the principle of "don't move people's cheese unnecessarily". Blazor apps in VS historically default to the BlazorApp name, but that changed with the move to the new New Project Dialog experience. This PR fixes that and avoids us having to update docs, screen shots, etc. Web apps have historically defaulted to WebApplication1, and I don't see any reason to change that. I brought up the Microsoft Style Guide purely to show that "app" is valid, not that it is always preferred.
@danroth27 I'll wait for you to sign off on this before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.