Skip to content

Conversation

mkArtakMSFT
Copy link
Contributor

No description provided.

@mkArtakMSFT mkArtakMSFT added the area-blazor Includes: Blazor, Razor Components label Jan 29, 2021
@mkArtakMSFT mkArtakMSFT added this to the 6.0-preview2 milestone Jan 29, 2021
@mkArtakMSFT mkArtakMSFT requested review from danroth27 and a team January 29, 2021 14:31
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jan 29, 2021
@mkArtakMSFT mkArtakMSFT changed the title Update Blazor App template name to BlazorApp Update Blazor Server App template name to BlazorApp Jan 29, 2021
@mkArtakMSFT mkArtakMSFT removed the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jan 29, 2021
@@ -445,7 +445,7 @@
"path": "BlazorServerWeb-CSharp.csproj"
}
],
"defaultName": "WebApplication",
"defaultName": "BlazorApp",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't abbreviate things on user displayed strings

Suggested change
"defaultName": "BlazorApp",
"defaultName": "BlazorApplication",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danroth27 I'll let you suggest the exact phrase here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App is not an abbreviation. It is a modern synonym for application. Examples of this usage include "Apple App Store". Use is "app" is preferred over "application" in the Microsoft Style Guide: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/a/app-application.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update WebApplication to WebApp to then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was motivated by the principle of "don't move people's cheese unnecessarily". Blazor apps in VS historically default to the BlazorApp name, but that changed with the move to the new New Project Dialog experience. This PR fixes that and avoids us having to update docs, screen shots, etc. Web apps have historically defaulted to WebApplication1, and I don't see any reason to change that. I brought up the Microsoft Style Guide purely to show that "app" is valid, not that it is always preferred.

@mkArtakMSFT
Copy link
Contributor Author

@danroth27 I'll wait for you to sign off on this before merging.

Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mkArtakMSFT mkArtakMSFT merged commit c8d536d into main Jan 29, 2021
@mkArtakMSFT mkArtakMSFT deleted the mkArtakMSFT-patch-1 branch January 29, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants