Skip to content

RazorPage: Allow IgnoreSection to specify sections that do not exist #29742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
3 commits merged into from
Feb 1, 2021
Merged

RazorPage: Allow IgnoreSection to specify sections that do not exist #29742

3 commits merged into from
Feb 1, 2021

Conversation

CodeBlanch
Copy link
Contributor

@CodeBlanch CodeBlanch commented Jan 28, 2021 •
edited
Loading

Updates IgnoreSection so it doesn't throw if the section being ignored is not found.

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jan 28, 2021
@CodeBlanch
Copy link
Contributor Author

Question on the tests: In RazorPageTest I see RenderSection tests that verify a throw, but nothing to verify required = false does not throw. Should I add these for the new IgnoreSection overload and the existing RenderSection overload which accepts required flag? Or just the new IgnoreSection overload? Or good as-is?

pranavkm
pranavkm reviewed Feb 1, 2021
View reviewed changes
@pranavkm pranavkm added the community-contribution Indicates that the PR has been added by a community member label Feb 1, 2021
@pranavkm pranavkm changed the title RazorPage: Add an IgnoreSection overload with a required parameter. RazorPage: Allow IgnoreSection to specify sections that do not exist Feb 1, 2021
pranavkm
pranavkm approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ghost
Copy link

ghost commented Feb 1, 2021

Hello @pranavkm!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@pranavkm pranavkm added this to the 6.0-preview2 milestone Feb 1, 2021
@ghost ghost merged commit 7e2ed4a into dotnet:main Feb 1, 2021
@CodeBlanch CodeBlanch deleted the ignoresection-required-flag branch August 5, 2021 19:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn Awaiting requested review from javiercn

1 more reviewer

@pranavkm pranavkm pranavkm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
6.0-preview2
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeBlanch @pranavkm