FunctionalTests - Clean up publish of deps.json #29449
Conversation
Pilchie
added
area-identity
HaoK
changed the title
| <WriteLinesToFile File="$(PublishDir)\contentroot.sln" Lines="Ignored" Overwrite="true" Encoding="Unicode" /> | ||
| <Target Name="PublishAssets" AfterTargets="Publish"> | ||
| <ItemGroup> | ||
| <_PublishFiles Include="$(ArtifactsBinDir)Microsoft.AspNetCore.Identity.UI\$(Configuration)\$(DefaultNetCoreTargetFramework)\Microsoft.AspNetCore.Identity.UI.Views.*.dll" /> |
There was a problem hiding this comment.
Looks like the UI functional tests need some additional dll/pages, in addition to the deps json
There was a problem hiding this comment.
Yep, these switch the application parts for testing V3 and V4 bootstrap I believe. We might be able to take them out of here since we removed bootstrap 3 support I believe, but we'll have to redo this work every time we have two ongoing supported versions.
There was a problem hiding this comment.
So these are fine to just leave for now in the csproj? The tests fail to run without these files
There was a problem hiding this comment.
@HaoK I see what you did now. It's glorious!!
| </ItemGroup> | ||
| <Copy SourceFiles="@(_PublishFiles)" DestinationFolder="$(PublishDir)" /> | ||
| </Target> | ||
|
|
There was a problem hiding this comment.
What was the magic behind removing this, we simply don't need it anymore? (We used to need it for application parts and Razor runtime compilation and we use the API within the WAF for something but can't remember where/why)
There was a problem hiding this comment.
These weren't here in the MVC Functionals csproj until my last PR, I just added them to copy over the deps file to get them to the publish directory for helix to pickup, that copy logic is now just in the build task, so this is just reverting the hack from the last PR
There was a problem hiding this comment.
That said, can you think of any reasons why script and link tags would change their rendering output now that they are running in the publish directory instead of the src directory? Is it something to do with how relative url/paths might render, and I just need to update the baselines?
There was a problem hiding this comment.
Release/Debug + Environment tag helper
There was a problem hiding this comment.
Ok I will follow up in a 3rd PR just looking at restoring those 2-3 skipped tests since this one is basically ready to go
| { | ||
| // When publishing content root is always the BaseDirectory | ||
| output[assemblyName] = "~"; | ||
| var depsFile = project.GetMetadata("DepsFile"); |
| Log.LogMessage("Looking for " + depsFile + ": "+ File.Exists(depsFile)); | ||
| if (File.Exists(depsFile)) | ||
| { | ||
| File.Copy(depsFile, Path.Combine(PathToCopyDeps, Path.GetFileName(depsFile))); |
There was a problem hiding this comment.
One small nit is that it might be better to do this within a target so that we can leverage <Copy which will do retries and so on.
I think it might be easier to just add these files to the resolvedfilestopublish itemgroup and that way it reuses the same standard insfrastructure.
There was a problem hiding this comment.
Cool, yeah that looks better than doing it in the task, updated with doing it in the targets file
|
@javiercn look good now for merge? |
Part of #27296