[release/5.0] Change bundle branding from '.Net Core' to '.Net' #28682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeloff
approved these changes
Dec 15, 2020
|
@wtgodbe It shouldn't. This information is only used in the registry when the bundle writes its registration data. Typically under HKLM\SOFTWARE\Microsoft\Updates (IIRC) It is a simple way to detect an installed bundle, but not a reliable key to use because OS updates can reset it. |
wtgodbe
added
the
tell-mode
JunTaoLuo
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28658
@joeloff the only instances of the string
BundleRegFamilyI found in the dotnet org are in this repo - will changing it from.Net Coreto.Netaffect any downstream repos?