Added IRequestDelegateFactory #27764
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove dictionary lookup and version check per request
- This will allow us to generate a unique request delegate based on the action descriptor at early in the pipeline.
ghost
added
the
area-mvc
|
I'm torn on whether this should be exposed, but we can always do that later I guess. |
halter73
reviewed
Nov 12, 2020
halter73
reviewed
Nov 12, 2020
| /// <summary> | ||
| /// Internal interfaces that allows us to optimize the request execution path based on ActionDescriptor | ||
| /// </summary> | ||
| internal interface IRequestDelegateFactory |
There was a problem hiding this comment.
It is a little odd to merge an abstraction without any implementations. I know there's https://github.com/dotnet/aspnetcore/blob/e9d16525cf3a832631a4e29ce826290adae873a9/src/Mvc/Mvc.Core/src/Routing/ControllerRequestDelegateFactory.cs ofc. Maybe we should wait for that or some other implementation of IRequestDelegateFactory to be ready before taking this.
There was a problem hiding this comment.
Agreed. I'll merge both PRs
|
Closed in favor of #27773 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PS: This is mostly plumbing code.