Skip to content

Conversation

Tratcher
Copy link
Member

This will get us much better coverage of newer windows features. The main question is if this queue can handle the load yet.

Contributes to https://github.com/dotnet/aspnetcore-internal/issues/3170.

@Tratcher Tratcher self-assigned this Sep 17, 2020
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 17, 2020
@Tratcher
Copy link
Member Author

@jkotalik @HaoK those are some interesting IIS setup failures. The tests are passed on this agent type in the helix matrix tests (unless they were skipped?). Any ideas?

@HaoK
Copy link
Member

HaoK commented Sep 18, 2020

Hrm, are all those failures related to cert installation?

@Tratcher
Copy link
Member Author

Those are the only failures I see, though there are a few at the top of the logs that indicate IIS Express isn't installed?

@HaoK
Copy link
Member

HaoK commented Sep 18, 2020

Can we add more logging to the setup operations so it prints out what its trying to do? Seems like a good opportunity to make this easier to debug for this, and the future...?

@jkotalik
Copy link
Contributor

Hm interesting. So this script was added to run on our CI because of some issues with the default certs for IISExpress. This was added quite a long time ago (2 years+) so I don't recall the exact details. So we went through all certs for ports 443** and recreated the cert.

You can try removing this script and see if the tests pass?

@Tratcher
Copy link
Member Author

Better, at least the IIS/Express tests aren't failing now. However, I don't think they're even running, they're set to skip if IIS/Express isn't installed.

The HttpSys failures are all HTTPS tests that try to re-use the IIS Express certificate bindings, which aren't present because of IIS Express not being installed.

@jkotalik
Copy link
Contributor

Better, at least the IIS/Express tests aren't failing now. However, I don't think they're even running, they're set to skip if IIS/Express isn't installed.

Oh, IIS Express isn't installed? That should be fixed. @dotnet/aspnet-build do you know who to contact about adding IISExpress to these new 201H1 agents?

@dougbu
Copy link
Contributor

dougbu commented Sep 21, 2020

do you know who to contact about adding IISExpress to these new 201H1 agents?

@Tratcher has been working with the right Core-Eng team members on the 20H1 agents. Suggest commenting on that issue (wherever it is) or continuing that thread.

@Tratcher
Copy link
Member Author

Tratcher commented Oct 1, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Tratcher
Copy link
Member Author

Tratcher commented Oct 7, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Tratcher
Copy link
Member Author

Tratcher commented Oct 8, 2020

Better, the IIS Express and HttpSys tests pass now. But now the IIS tests are failing.

System.AggregateException : One or more errors occurred. (Operation did not succeed after 15 retries (Retrieving the COM class factory for component with CLSID {2B72133B-3F5B-4602-8952-803546CE3344} failed due to the following error: 80040154 Class not registered (0x80040154 (REGDB_E_CLASSNOTREG)).)

I know IIS isn't installed yet on this new queue, but I thought those tests were better about skipping if it wasn't installed?

@Tratcher Tratcher marked this pull request as ready for review October 9, 2020 14:02
@Tratcher Tratcher requested a review from dougbu October 9, 2020 14:02
<ItemGroup Condition="'$(IsRequiredCheck)' == 'true' AND '$(TargetArchitecture)' == 'x64'">
<HelixAvailableTargetQueue Include="Ubuntu.1604.Amd64.Open" Platform="Linux" />
<HelixAvailableTargetQueue Include="Windows.10.Amd64.Open" Platform="Windows" />
<HelixAvailableTargetQueue Include="Windows.10.Amd64.Server20H1.Open" Platform="Windows" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many machines are in this target queue? I'd be concerned if there isn't enough machines.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've already been using it for nightly runs. The more we use it the more machines they allocate to it. There may be a temporary lag while it catches up.

@Tratcher Tratcher merged commit 36f6242 into master Oct 9, 2020
@Tratcher Tratcher deleted the tratcher/20h1 branch October 9, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants