-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Use 201H1 all the time #26037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 201H1 all the time #26037
Conversation
Hrm, are all those failures related to cert installation? |
Those are the only failures I see, though there are a few at the top of the logs that indicate IIS Express isn't installed? |
Can we add more logging to the setup operations so it prints out what its trying to do? Seems like a good opportunity to make this easier to debug for this, and the future...? |
Hm interesting. So this script was added to run on our CI because of some issues with the default certs for IISExpress. This was added quite a long time ago (2 years+) so I don't recall the exact details. So we went through all certs for ports 443** and recreated the cert. You can try removing this script and see if the tests pass? |
Better, at least the IIS/Express tests aren't failing now. However, I don't think they're even running, they're set to skip if IIS/Express isn't installed. The HttpSys failures are all HTTPS tests that try to re-use the IIS Express certificate bindings, which aren't present because of IIS Express not being installed. |
Oh, IIS Express isn't installed? That should be fixed. @dotnet/aspnet-build do you know who to contact about adding IISExpress to these new 201H1 agents? |
@Tratcher has been working with the right Core-Eng team members on the 20H1 agents. Suggest commenting on that issue (wherever it is) or continuing that thread. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Better, the IIS Express and HttpSys tests pass now. But now the IIS tests are failing.
I know IIS isn't installed yet on this new queue, but I thought those tests were better about skipping if it wasn't installed? |
<ItemGroup Condition="'$(IsRequiredCheck)' == 'true' AND '$(TargetArchitecture)' == 'x64'"> | ||
<HelixAvailableTargetQueue Include="Ubuntu.1604.Amd64.Open" Platform="Linux" /> | ||
<HelixAvailableTargetQueue Include="Windows.10.Amd64.Open" Platform="Windows" /> | ||
<HelixAvailableTargetQueue Include="Windows.10.Amd64.Server20H1.Open" Platform="Windows" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How many machines are in this target queue? I'd be concerned if there isn't enough machines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've already been using it for nightly runs. The more we use it the more machines they allocate to it. There may be a temporary lag while it catches up.
This will get us much better coverage of newer windows features. The main question is if this queue can handle the load yet.
Contributes to https://github.com/dotnet/aspnetcore-internal/issues/3170.