Skip to content

Add SkipAnalyzers=true to component declaration compilation #25736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 14, 2020
Merged

Add SkipAnalyzers=true to component declaration compilation #25736

merged 11 commits into from
Sep 14, 2020

Conversation

pranavkm
Copy link
Contributor

@pranavkm pranavkm commented Sep 9, 2020

Fixes #25365

@pranavkm
Update to latest SDK
343e7ab 
* React to platform compatibility analyzer warnings
* React to new warnings
* Add platform compatibility attributes
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Sep 9, 2020
@pranavkm pranavkm mentioned this pull request Sep 9, 2020
Closed
@pranavkm pranavkm force-pushed the prkrishn/skip-analyzers branch from 4ae45e5 to 726148c Compare September 10, 2020 21:01
@pranavkm pranavkm marked this pull request as ready for review September 10, 2020 21:22
@pranavkm pranavkm requested a review from dougbu as a code owner September 10, 2020 21:22
pranavkm
pranavkm commented Sep 10, 2020
View reviewed changes
pranavkm
pranavkm commented Sep 10, 2020
View reviewed changes
dougbu
dougbu approved these changes Sep 10, 2020
View reviewed changes
Base automatically changed from prkrishn/platform-attributes to release/5.0-rc2 September 10, 2020 22:12
@mkArtakMSFT mkArtakMSFT requested a review from a team September 10, 2020 22:12
@pranavkm
Copy link
Contributor Author

@Pilchie one more for rc2.

@Pilchie Pilchie added the Servicing-approved Shiproom has approved the issue label Sep 10, 2020
@Pilchie
Copy link
Member

Pilchie commented Sep 10, 2020

Approved for .NET Core 5.0 RC2 pending CI Completion.

@mkArtakMSFT mkArtakMSFT merged commit a6f667b into release/5.0-rc2 Sep 14, 2020
@mkArtakMSFT mkArtakMSFT deleted the prkrishn/skip-analyzers branch September 14, 2020 19:41
@dougbu dougbu mentioned this pull request Oct 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

@halter73 halter73 Awaiting requested review from halter73

@javiercn javiercn Awaiting requested review from javiercn

@jkotalik jkotalik Awaiting requested review from jkotalik

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

@Tratcher Tratcher Awaiting requested review from Tratcher

1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Servicing-approved Shiproom has approved the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pranavkm @Pilchie @dougbu @mkArtakMSFT