Skip to content

Fix SignalR typescript tests with Chrome SameSite reaction (#25283) #25473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix SignalR typescript tests with Chrome SameSite reaction (#25283) #25473

wants to merge 1 commit into from

Conversation

BrennanConroy
Copy link
Member

Backport test fixes from #25283

@BrennanConroy BrennanConroy added the area-signalr Includes: SignalR clients and servers label Aug 31, 2020
@BrennanConroy BrennanConroy added this to the 3.1.x milestone Aug 31, 2020
@BrennanConroy BrennanConroy requested review from halter73 and a team August 31, 2020 22:18
@dougbu dougbu mentioned this pull request Aug 31, 2020
Merged
dougbu
dougbu approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM once CI passes and the branches open for 3.1.9

@dougbu
Copy link
Contributor

dougbu commented Aug 31, 2020

Since this PR is test-only, I suggest marking it as tell-mode

@BrennanConroy BrennanConroy added the tell-mode Indicates a PR which is being merged during tell-mode label Aug 31, 2020
@dougbu dougbu mentioned this pull request Sep 1, 2020
Merged
@BrennanConroy
Copy link
Member Author

Closing in favor of #25324

@BrennanConroy BrennanConroy deleted the brecon/chrome2 branch September 1, 2020 00:59
@dougbu dougbu removed this from the 3.1.x milestone Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-signalr Includes: SignalR clients and servers tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrennanConroy @dougbu