Skip to content

Conversation

ajaybhargavb
Copy link
Contributor

@ajaybhargavb ajaybhargavb commented Aug 31, 2020

@ajaybhargavb ajaybhargavb requested a review from JunTaoLuo August 31, 2020 18:55
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 31, 2020
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General change seems good, but don't merge until you verify the internal build is fixed

@ajaybhargavb ajaybhargavb force-pushed the ajbaaska/fix-daily-test branch from abb17ae to 5e2877c Compare September 4, 2020 20:11
@pranavkm
Copy link
Contributor

@ajaybhargavb can this be merged?

@ajaybhargavb
Copy link
Contributor Author

@pranavkm not yet. It is now running on SauceLabs but I am seeing failures. I haven't had the chance to investigate them yet.

@ajaybhargavb ajaybhargavb merged commit 9939b33 into master Oct 7, 2020
@ajaybhargavb ajaybhargavb deleted the ajbaaska/fix-daily-test branch October 7, 2020 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants