Skip to content

Correct the site extensions builds #25406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2020
Merged

Correct the site extensions builds #25406

merged 1 commit into from
Aug 31, 2020

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Aug 29, 2020

  • handle differing SiteExtensions package versions
    • the arch-specific packages don't stabilize when final package does
  • remove 2.2 package from the site extensions bundle
  • update 3.1 packages in bundle to 3.1.7 version
  • remove useless empty folder from LoggingBranch (arch-specific) package
    • double slashes help nobody but add an empty-named level in the package

nit: fix a binary log filename

@dougbu dougbu requested review from BrennanConroy and a team August 29, 2020 18:41
@dougbu
Copy link
Contributor Author

dougbu commented Aug 29, 2020

This was part of #24983 but I found it's mandatory for us to build with stable versions. That is, the servicing readiness tests failed without this work.

@dougbu
Copy link
Contributor Author

dougbu commented Aug 29, 2020

Internal build https://dev.azure.com/dnceng/internal/_build/results?buildId=793405 included this commit if you want to see the created packages

@dougbu dougbu added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform tell-mode Indicates a PR which is being merged during tell-mode labels Aug 29, 2020
@dougbu
Copy link
Contributor Author

dougbu commented Aug 29, 2020

@Pilchie any objection to tell-mode here❔

@Pilchie
Copy link
Member

Pilchie commented Aug 29, 2020

I'm not against tell-mode, but I'm not sure that removing 2.2 is the right thing to do. Even though it's out of support, 2.2 is still available on Azure AppService :(

@dougbu
Copy link
Contributor Author

dougbu commented Aug 29, 2020

I'm not sure that removing 2.2 is the right thing to do

Thought we'd decided it was fine in the "[dotnet/aspnetcore] Update branding to 6.0.0 Alpha1 (#24983)" email thread (outside the referenced PR)❔

@BrennanConroy
Copy link
Member

It's easier to just keep 2.2 there and we can remove it in 6.0

wtgodbe
wtgodbe approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good contingent on resolution of the 2.2 issue. Makes sense to me to keep including the 2.2 packages for now

@dougbu
Correct the site extensions builds
4a2937a 
- handle differing SiteExtensions package versions
  - the arch-specific packages don't stabilize when final package does
- update 3.1 packages in bundle to 3.1.7 version
- remove useless empty folder from LoggingBranch (arch-specific) package
  - double slashes help nobody but add an empty-named level in the package

nit: fix a binary log filename
@dougbu dougbu force-pushed the dougbu/site.extension.servicing branch from 0fdf17d to 4a2937a Compare August 31, 2020 17:24
@dougbu
Copy link
Contributor Author

dougbu commented Aug 31, 2020

🆙📅 to rebase and restore the 2.2 site extensions inclusion in the bundle (this time in the correct PR 😺)

@dougbu dougbu merged commit 2758254 into release/5.0 Aug 31, 2020
@dougbu dougbu deleted the dougbu/site.extension.servicing branch August 31, 2020 19:26
@dougbu dougbu mentioned this pull request Sep 2, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dougbu @Pilchie @BrennanConroy @wtgodbe