Fix chrome/selenium tests #25330
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,10 @@ | |
| using System.Threading.Tasks; | ||
| using OpenQA.Selenium; | ||
| using OpenQA.Selenium.Chrome; | ||
| using OpenQA.Selenium.Edge; | ||
| using OpenQA.Selenium.IE; | ||
| using OpenQA.Selenium.Remote; | ||
| using OpenQA.Selenium.Safari; | ||
| using Xunit; | ||
| using Xunit.Abstractions; | ||
|
|
||
|
|
@@ -234,55 +237,75 @@ private string UserProfileDirectory(string context) | |
| name = $"{name} - {context}"; | ||
| } | ||
|
|
||
| DriverOptions options; | ||
|
|
||
| switch (sauce.BrowserName.ToLower()) | ||
| { | ||
| case "chrome": | ||
| options = new ChromeOptions(); | ||
| break; | ||
| case "safari": | ||
| options = new SafariOptions(); | ||
| break; | ||
| case "internet explorer": | ||
| options = new InternetExplorerOptions(); | ||
| break; | ||
| case "microsoftedge": | ||
| options = new EdgeOptions(); | ||
| break; | ||
| default: | ||
| throw new InvalidOperationException($"Browser name {sauce.BrowserName} not recognized"); | ||
| } | ||
|
There was a problem hiding this comment. Why do we need this? We ended up not going this route @ajaybhargavb isn't that the case? We only need chrome I believe There was a problem hiding this comment. We only need Chrome for local and CI tests. But we use other browsers when running in SauceLabs. We need to pass in the correct options to SauceLabs in that case. There was a problem hiding this comment. @ajaybhargavb but do we actually run in SauceLabs? I thought we discarded that idea. That's why I'm asking. There was a problem hiding this comment. We still want to. What we discarded was the idea to do real device testing on SauceLabs. |
||
|
|
||
| // Required config | ||
| options.AddAdditionalOption("username", sauce.Username); | ||
| options.AddAdditionalOption("accessKey", sauce.AccessKey); | ||
| options.AddAdditionalOption("tunnelIdentifier", sauce.TunnelIdentifier); | ||
| options.AddAdditionalOption("name", name); | ||
|
|
||
| if (!string.IsNullOrEmpty(sauce.BrowserName)) | ||
| { | ||
| options.AddAdditionalOption("browserName", sauce.BrowserName); | ||
| } | ||
|
|
||
| if (!string.IsNullOrEmpty(sauce.PlatformVersion)) | ||
| { | ||
| options.PlatformName = sauce.PlatformName; | ||
| options.AddAdditionalOption("platformVersion", sauce.PlatformVersion); | ||
| } | ||
| else | ||
| { | ||
| // In some cases (like macOS), SauceLabs expects us to set "platform" instead of "platformName". | ||
| options.AddAdditionalOption("platform", sauce.PlatformName); | ||
| } | ||
|
|
||
| if (!string.IsNullOrEmpty(sauce.BrowserVersion)) | ||
| { | ||
| options.BrowserVersion = sauce.BrowserVersion; | ||
| } | ||
|
|
||
| if (!string.IsNullOrEmpty(sauce.DeviceName)) | ||
| { | ||
| options.AddAdditionalOption("deviceName", sauce.DeviceName); | ||
| } | ||
|
|
||
| if (!string.IsNullOrEmpty(sauce.DeviceOrientation)) | ||
| { | ||
| options.AddAdditionalOption("deviceOrientation", sauce.DeviceOrientation); | ||
| } | ||
|
|
||
| if (!string.IsNullOrEmpty(sauce.AppiumVersion)) | ||
| { | ||
| options.AddAdditionalOption("appiumVersion", sauce.AppiumVersion); | ||
| } | ||
|
|
||
| if (!string.IsNullOrEmpty(sauce.SeleniumVersion)) | ||
| { | ||
| options.AddAdditionalOption("seleniumVersion", sauce.SeleniumVersion); | ||
| } | ||
|
|
||
| var capabilities = options.ToCapabilities(); | ||
|
|
||
| await SauceConnectServer.StartAsync(output); | ||
|
|
||
| var attempt = 0; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| { | ||
| "drivers": { | ||
| "chrome": { | ||
| "version" : "85.0.4183.87" | ||
| } | ||
| }, | ||
| "ignoreExtraDrivers": true | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pretty big jump. Did something change with the way the package is versioned?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, they moved to use versions matching Chrome versions. There as a jump from v.2.46.0 to v.71.0.3578.137 a while back.
In addition, we were almost 2 years out-of-date in using v2.43.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. That makes sense.
How does this mesh with the fact that we don't control what version of Chrome is downloaded with the installer (AFAIK)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should mean we can be proactive. Whenever a dev notices their Chrome installation wants to be restarted, they can check whether it's a new major version and update this particular package version. Or, @sebastienros could add a reminder to check the Selenium versions in his ops rotation invites every few (10?) rotations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could, I am afraid I will forget ;) I would suggest to update the operations book, and let's say "if your rotation happens on the first Tuesday of the month then you should ..."
Mondays are frequently skipped due to holidays
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. May also need something in https://github.com/dotnet/aspnetcore-internal/blob/master/.github/ISSUE_TEMPLATE/Build_OPS_handoff.md @JunTaoLuo what do you think❔