Skip to content

Pass generators to CSC during component discovery #25292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 28, 2020
Merged

Pass generators to CSC during component discovery #25292

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d959084
Pass generators to CSC during component discovery
chsienki Aug 26, 2020
866df80
Disable compiler warnings during component discovery phase
chsienki Aug 27, 2020
aa51b8c
Remove unsupported SkipAnalyzers param
chsienki Aug 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...icrosoft.NET.Sdk.Razor/src/build/netstandard2.0/Microsoft.NET.Sdk.Razor.Component.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ Copyright (c) .NET Foundation. All rights reserved.
AddModules="@(AddModules)"
AdditionalFiles="@(AdditionalFiles)"
AllowUnsafeBlocks="$(AllowUnsafeBlocks)"
Analyzers="@(Analyzer)"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranavkm couldn't we just remove the ANalyzers from this phase wholesale?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source generators are also considered analyzers, and they need to happen in this phase.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thats the problem, and why we added the new SkipAnalyzers argument.

Equally we're going to have this issue if a generator emits a warning too, so we might need to re-think the strategy a little bit? I wonder if we should just disable all wanings (-warn 0) for the component discovery phase? That way any warnings would only show up in the second phase, and errors in the first phase would stop the second running anyway.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give bumping up the SDK another try. If we get it updated to the latest and greatest, perhaps we get this change in as-is.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should just disable all wanings (-warn 0) for the component discovery phase? That way any warnings would only show up in the second phase, and errors in the first phase would stop the second running anyway.

ya I think that'd be best

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've disabled warnings and removed the SkipAnalyzers param. Means that phase might be a little slower until you upgrade the SDK and can use it again, but everything should work as expected.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we file a follow up issue to move to SkipAnalyzers at some point in the future?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll open an issue to track.

ApplicationConfiguration="$(AppConfigForCompiler)"
BaseAddress="$(BaseAddress)"
CheckForOverflowUnderflow="$(CheckForOverflowUnderflow)"
Expand Down Expand Up @@ -242,7 +243,7 @@ Copyright (c) .NET Foundation. All rights reserved.
UseSharedCompilation="$(UseSharedCompilation)"
Utf8Output="$(Utf8Output)"
VsSessionGuid="$(VsSessionGuid)"
WarningLevel="$(WarningLevel)"
WarningLevel="0"
WarningsAsErrors="$(WarningsAsErrors)"
WarningsNotAsErrors="$(WarningsNotAsErrors)"
PathMap="$(PathMap)"
Expand Down